From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org,
Magnus Kulke <magnus.kulke@linux.microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Warner Losh <imp@bsdimp.com>,
Kyle Evans <kevans@freebsd.org>,
Richard Henderson <richard.henderson@linaro.org>,
Helge Deller <deller@gmx.de>,
Michael Roth <michael.roth@amd.com>,
Kostiantyn Kostiuk <kkostiuk@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 3/4] misc: Clean up includes
Date: Fri, 16 Jan 2026 14:20:57 +0100 [thread overview]
Message-ID: <87ecnpwv5y.fsf@pond.sub.org> (raw)
In-Reply-To: <20260116125830.926296-4-peter.maydell@linaro.org> (Peter Maydell's message of "Fri, 16 Jan 2026 12:58:29 +0000")
Peter Maydell <peter.maydell@linaro.org> writes:
> This commit deals with various .c files that included system
> headers that are already pulled in by osdep.h, where the .c
> file includes osdep.h already itself.
>
> This commit was created with scripts/clean-includes:
> ./scripts/clean-includes '--git' 'misc' 'hw/core' 'semihosting' 'target/arm' 'target/i386/kvm/kvm.c' 'target/loongarch' 'target/riscv' 'tools' 'util'
>
> All .c should include qemu/osdep.h first. The script performs three
> related cleanups:
>
> * Ensure .c files include qemu/osdep.h first.
> * Including it in a .h is redundant, since the .c already includes
> it. Drop such inclusions.
> * Likewise, including headers qemu/osdep.h includes is redundant.
> Drop these, too.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2026-01-16 13:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 12:58 [PATCH 0/4] misc: clean up includes Peter Maydell
2026-01-16 12:58 ` [PATCH 1/4] mshv: Clean " Peter Maydell
2026-01-16 13:07 ` Philippe Mathieu-Daudé
2026-01-16 12:58 ` [PATCH 2/4] bsd-user: " Peter Maydell
2026-01-16 13:06 ` Philippe Mathieu-Daudé
2026-01-16 14:28 ` Warner Losh
2026-01-16 12:58 ` [PATCH 3/4] misc: " Peter Maydell
2026-01-16 13:20 ` Markus Armbruster [this message]
2026-01-16 13:37 ` Philippe Mathieu-Daudé
2026-01-16 12:58 ` [PATCH 4/4] all: " Peter Maydell
2026-01-16 13:06 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecnpwv5y.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=deller@gmx.de \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=kkostiuk@redhat.com \
--cc=magnus.kulke@linux.microsoft.com \
--cc=michael.roth@amd.com \
--cc=mtosatti@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.