All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] docs: replace a duplicated word and add missing SPDX-License tag
@ 2025-08-19 11:35 Bartlomiej Kubik
  2025-08-19 17:19 ` Randy Dunlap
  2025-08-21 17:58 ` Jonathan Corbet
  0 siblings, 2 replies; 4+ messages in thread
From: Bartlomiej Kubik @ 2025-08-19 11:35 UTC (permalink / raw)
  To: corbet; +Cc: skhan, linux-doc, linux-kernel-mentees, rdunlap, Bartlomiej Kubik

Fix documentation issues by removing a duplicated word and adding the
missing SPDX-License identifier.

Signed-off-by: Bartlomiej Kubik <kubik.bartlomiej@gmail.com>
---

Changelog:

Changes since v2:
- Replace “that” with “the.”

Changes since v1:		
- Add missing SPDX-License tag
- Remove duplicated word "that"

 Documentation/admin-guide/kernel-parameters.rst | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/kernel-parameters.rst b/Documentation/admin-guide/kernel-parameters.rst
index 39d0e7ff0965..7bf8cc7df6b5 100644
--- a/Documentation/admin-guide/kernel-parameters.rst
+++ b/Documentation/admin-guide/kernel-parameters.rst
@@ -1,3 +1,5 @@
+.. SPDX-License-Identifier: GPL-2.0
+
 .. _kernelparameters:
 
 The kernel's command-line parameters
@@ -213,7 +215,7 @@ need or coordination with <Documentation/arch/x86/boot.rst>.
 There are also arch-specific kernel-parameters not documented here.
 
 Note that ALL kernel parameters listed below are CASE SENSITIVE, and that
-a trailing = on the name of any parameter states that that parameter will
+a trailing = on the name of any parameter states that the parameter will
 be entered as an environment variable, whereas its absence indicates that
 it will appear as a kernel argument readable via /proc/cmdline by programs
 running once the system is up.
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] docs: replace a duplicated word and add missing SPDX-License tag
  2025-08-19 11:35 [PATCH v3] docs: replace a duplicated word and add missing SPDX-License tag Bartlomiej Kubik
@ 2025-08-19 17:19 ` Randy Dunlap
  2025-08-21 17:58 ` Jonathan Corbet
  1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2025-08-19 17:19 UTC (permalink / raw)
  To: Bartlomiej Kubik, corbet; +Cc: skhan, linux-doc, linux-kernel-mentees



On 8/19/25 4:35 AM, Bartlomiej Kubik wrote:
> Fix documentation issues by removing a duplicated word and adding the
> missing SPDX-License identifier.
> 
> Signed-off-by: Bartlomiej Kubik <kubik.bartlomiej@gmail.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> 
> Changelog:
> 
> Changes since v2:
> - Replace “that” with “the.”
> 
> Changes since v1:		
> - Add missing SPDX-License tag
> - Remove duplicated word "that"
> 
>  Documentation/admin-guide/kernel-parameters.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.rst b/Documentation/admin-guide/kernel-parameters.rst
> index 39d0e7ff0965..7bf8cc7df6b5 100644
> --- a/Documentation/admin-guide/kernel-parameters.rst
> +++ b/Documentation/admin-guide/kernel-parameters.rst
> @@ -1,3 +1,5 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
>  .. _kernelparameters:
>  
>  The kernel's command-line parameters
> @@ -213,7 +215,7 @@ need or coordination with <Documentation/arch/x86/boot.rst>.
>  There are also arch-specific kernel-parameters not documented here.
>  
>  Note that ALL kernel parameters listed below are CASE SENSITIVE, and that
> -a trailing = on the name of any parameter states that that parameter will
> +a trailing = on the name of any parameter states that the parameter will
>  be entered as an environment variable, whereas its absence indicates that
>  it will appear as a kernel argument readable via /proc/cmdline by programs
>  running once the system is up.

-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] docs: replace a duplicated word and add missing SPDX-License tag
  2025-08-19 11:35 [PATCH v3] docs: replace a duplicated word and add missing SPDX-License tag Bartlomiej Kubik
  2025-08-19 17:19 ` Randy Dunlap
@ 2025-08-21 17:58 ` Jonathan Corbet
  2025-08-22  9:28   ` Bartłomiej Kubik
  1 sibling, 1 reply; 4+ messages in thread
From: Jonathan Corbet @ 2025-08-21 17:58 UTC (permalink / raw)
  To: Bartlomiej Kubik
  Cc: skhan, linux-doc, linux-kernel-mentees, rdunlap, Bartlomiej Kubik

Bartlomiej Kubik <kubik.bartlomiej@gmail.com> writes:

> Fix documentation issues by removing a duplicated word and adding the
> missing SPDX-License identifier.
>
> Signed-off-by: Bartlomiej Kubik <kubik.bartlomiej@gmail.com>
> ---
>
> Changelog:
>
> Changes since v2:
> - Replace “that” with “the.”
>
> Changes since v1:		
> - Add missing SPDX-License tag
> - Remove duplicated word "that"
>
>  Documentation/admin-guide/kernel-parameters.rst | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

A couple of minor notes:

- It is good to indicate *which* file you are modifying; I've rewritten
  the subject line to that end.

- Adding SPDX headers is a bit fraught unless you are truly sure of the
  license under which the file was contributed.  Given the nature of
  this file and all of the people who have touched it, though, GPLv2 is
  the only option that makes any sense.

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] docs: replace a duplicated word and add missing SPDX-License tag
  2025-08-21 17:58 ` Jonathan Corbet
@ 2025-08-22  9:28   ` Bartłomiej Kubik
  0 siblings, 0 replies; 4+ messages in thread
From: Bartłomiej Kubik @ 2025-08-22  9:28 UTC (permalink / raw)
  To: Jonathan Corbet; +Cc: skhan, linux-doc, linux-kernel-mentees, rdunlap

Hi,

Many thanks for your feedback and review.
I will keep them in mind when working on upcoming patches.


On Thu, 21 Aug 2025 at 19:58, Jonathan Corbet <corbet@lwn.net> wrote:
>
> Bartlomiej Kubik <kubik.bartlomiej@gmail.com> writes:
>
> > Fix documentation issues by removing a duplicated word and adding the
> > missing SPDX-License identifier.
> >
> > Signed-off-by: Bartlomiej Kubik <kubik.bartlomiej@gmail.com>
> > ---
> >
> > Changelog:
> >
> > Changes since v2:
> > - Replace “that” with “the.”
> >
> > Changes since v1:
> > - Add missing SPDX-License tag
> > - Remove duplicated word "that"
> >
> >  Documentation/admin-guide/kernel-parameters.rst | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
>
> A couple of minor notes:
>
> - It is good to indicate *which* file you are modifying; I've rewritten
>   the subject line to that end.
>
> - Adding SPDX headers is a bit fraught unless you are truly sure of the
>   license under which the file was contributed.  Given the nature of
>   this file and all of the people who have touched it, though, GPLv2 is
>   the only option that makes any sense.
>
> Applied, thanks.
>
> jon



-- 
Best regards
Bartłomiej Kubik

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-22  9:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 11:35 [PATCH v3] docs: replace a duplicated word and add missing SPDX-License tag Bartlomiej Kubik
2025-08-19 17:19 ` Randy Dunlap
2025-08-21 17:58 ` Jonathan Corbet
2025-08-22  9:28   ` Bartłomiej Kubik

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.