From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Andrew Melnychenko <andrew@daynix.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: ebpf functions can fail without setting an error
Date: Thu, 07 Aug 2025 15:14:56 +0200 [thread overview]
Message-ID: <87ectns27j.fsf@pond.sub.org> (raw)
Three functions in ebpf_rss.h take an Error ** argument and return bool.
Good.
They can all fail without setting an error. Not good.
The failures without error are:
* All three stubs in ebpf_rss-stub.c always. Oversight?
* Non-stub ebpf_rss_load() when ebpf_rss_is_loaded(). Are these
reachable?
next reply other threads:[~2025-08-07 13:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 13:14 Markus Armbruster [this message]
2025-08-19 10:48 ` ebpf functions can fail without setting an error Daniel P. Berrangé
2025-08-25 12:19 ` Markus Armbruster
2025-08-25 13:27 ` Philippe Mathieu-Daudé
2025-08-27 8:13 ` Markus Armbruster
2025-09-17 8:24 ` Akihiko Odaki
2025-11-17 13:58 ` Markus Armbruster
2025-11-17 15:06 ` Daniel P. Berrangé
2025-11-18 12:13 ` Markus Armbruster
2025-11-18 12:23 ` Daniel P. Berrangé
2025-11-18 12:25 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ectns27j.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=andrew@daynix.com \
--cc=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.