Re: ebpf functions can fail without setting an error

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Aug 07, 2025 at 03:14:56PM +0200, Markus Armbruster wrote:
> Three functions in ebpf_rss.h take an Error ** argument and return bool.
> Good.
> 
> They can all fail without setting an error.  Not good.
> 
> The failures without error are:
> 
> * All three stubs in ebpf_rss-stub.c always.  Oversight?

Opps, yes, we really should have added error_setg() calls for diagnosis
if someone tries to use eBPF when QEMU build has it disabled.

> * Non-stub ebpf_rss_load() when ebpf_rss_is_loaded().  Are these
>   reachable?

This scenario should never happen, and we should add a call like

  error_setg(errp, "eBPF program is already loaded");

to report it correctly.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|