From: Takashi Iwai <tiwai@suse.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Sharan Kumar Muthu Saravanan <sharweshraajan@gmail.com>,
tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx
Date: Thu, 17 Jul 2025 12:07:46 +0200 [thread overview]
Message-ID: <87ecuf9ll9.wl-tiwai@suse.de> (raw)
In-Reply-To: <87jz479m96.wl-tiwai@suse.de>
On Thu, 17 Jul 2025 11:53:25 +0200,
Takashi Iwai wrote:
>
> On Thu, 17 Jul 2025 05:02:19 +0200,
> Sharan Kumar Muthu Saravanan wrote:
> >
> > this patch is to fix my previous Commit e518230 i have fixed mute led
> > but for by This patch corrects the coefficient mask value introduced
> > in commit e518230, which was intended to enable the mute LED
> > functionality. During testing, multiple values were evaluated, and an
> > incorrect value was mistakenly included in the final commit. This
> > update fixes that error by applying the correct mask value for proper
> > mute LED behavior.
> >
> > Tested on 6.15.5-arch1-1
> >
> > Signed-off-by: M SHARAN KUMAR <sharweshraajan@gmail.com>
>
> The patch is still not applicable cleanly.
> Please try to fix the mailer setup and resubmit. At best, test to
> send a patch to yourself, and try to apply the patch by yourself,
> before resubmitting.
>
> Also, don't forget to add the proper Fixes tag pointing to the
> commit. It must be with 12 chars SHA1 ID followed by the commit
> summary. See Documentation/process/submitting-patches.rst for
> details.
Last but not least: please use the proper subject line.
The subject of this patch is *exactly* same as the commit you're
trying to fix. This patch isn't about enabling the mute LED; it's
correcting the bug introduced by the previous patch.
Takashi
next prev parent reply other threads:[~2025-07-17 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 3:02 [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx Sharan Kumar Muthu Saravanan
2025-07-17 9:53 ` Takashi Iwai
2025-07-17 10:07 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-07-11 6:23 Sharan Kumar Muthu Saravanan
2025-07-11 7:34 ` Takashi Iwai
2025-03-29 15:41 Sharan Kumar M
2025-03-31 9:31 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecuf9ll9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=sharweshraajan@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.