Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[Takashi Iwai <tiwai@suse.de>]

On Fri, 11 Jul 2025 08:23:09 +0200,
Sharan Kumar Muthu Saravanan wrote:
> 
> this patch makes the mute led brighter since the previous patch i
> submitted was dim
> 
> Tested on 6.15.5-arch1-1
> 
> Signed-off-by: Sharan Kumar M <sharweshraajan@gmail.com>
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 060db37eab83..062d439e753d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4753,7 +4753,7 @@ static void
> alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
>         if (action == HDA_FIXUP_ACT_PRE_PROBE) {
>                 spec->mute_led_polarity = 0;
>                 spec->mute_led_coef.idx = 0x0b;
> -               spec->mute_led_coef.mask = 1 << 3;
> +               spec->mute_led_coef.mask = 3 << 2;
>                 spec->mute_led_coef.on = 1 << 3;
>                 spec->mute_led_coef.off = 0;
>                 snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
> ---

The patch isn't applicable cleanly at all.
Please try to submit in a proper format.  At best, test by yourself
whether you can apply the patch locally before the next submission.

Also, the patch description is too ambiguous.  Please describe more
exactly what was wrong and what you changed.

Last but not least, please add Fixes tag pointing to your previous fix
mentioned in the patch.


thanks,

Takashi