All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-bad: webrtc needs sync_4
@ 2025-06-08 11:09 Julien Olivain
  2025-06-09 14:22 ` Peter Korsgaard
  2025-06-12 20:10 ` Arnout Vandecappelle via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Julien Olivain @ 2025-06-08 11:09 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain, Thomas Bonnefille

Commit [1] "package/gstreamer1/gst1-plugins-bad: bump version
to 1.24.11" added new requirements for webrtc which selects the
sctp plugin, but forgot to propagate its dependencies. The sctp
plugin depends on BR2_TOOLCHAIN_HAS_SYNC_4.

This commit fixes this issue.

Fixes:

    WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SCTP
      Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BAD [=y] && BR2_TOOLCHAIN_HAS_SYNC_4 [=n]
      Selected by [y]:
      - BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC [=y] && BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BAD [=y] && !BR2_STATIC_LIBS [=n]

[1] https://gitlab.com/buildroot.org/buildroot/-/commit/90b3cfedf44cc92289746aa30e439be409ca3747

Cc: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 package/gstreamer1/gst1-plugins-bad/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
index 4c4e993714..89db860f87 100644
--- a/package/gstreamer1/gst1-plugins-bad/Config.in
+++ b/package/gstreamer1/gst1-plugins-bad/Config.in
@@ -659,6 +659,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBP
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC
 	bool "webrtc"
 	depends on !BR2_STATIC_LIBS # libnice -> gnutls
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # gst1-plugins-bad sctp
 	select BR2_PACKAGE_GST1_PLUGINS_BASE # libgstsdp
 	select BR2_PACKAGE_LIBNICE
 	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DTLS
@@ -669,6 +670,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC
 
 comment "webrtc needs a toolchain w/ dynamic library"
 	depends on BR2_STATIC_LIBS
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTCDSP
 	bool "webrtcdsp"
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-bad: webrtc needs sync_4
  2025-06-08 11:09 [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-bad: webrtc needs sync_4 Julien Olivain
@ 2025-06-09 14:22 ` Peter Korsgaard
  2025-06-12 20:10 ` Arnout Vandecappelle via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2025-06-09 14:22 UTC (permalink / raw)
  To: Julien Olivain; +Cc: buildroot, Thomas Bonnefille

>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > Commit [1] "package/gstreamer1/gst1-plugins-bad: bump version
 > to 1.24.11" added new requirements for webrtc which selects the
 > sctp plugin, but forgot to propagate its dependencies. The sctp
 > plugin depends on BR2_TOOLCHAIN_HAS_SYNC_4.

 > This commit fixes this issue.

 > Fixes:

 >     WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SCTP
 >       Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BAD [=y] && BR2_TOOLCHAIN_HAS_SYNC_4 [=n]
 >       Selected by [y]:
 >       - BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC [=y] && BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BAD [=y] && !BR2_STATIC_LIBS [=n]

 > [1] https://gitlab.com/buildroot.org/buildroot/-/commit/90b3cfedf44cc92289746aa30e439be409ca3747

 > Cc: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
 > Signed-off-by: Julien Olivain <ju.o@free.fr>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-bad: webrtc needs sync_4
  2025-06-08 11:09 [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-bad: webrtc needs sync_4 Julien Olivain
  2025-06-09 14:22 ` Peter Korsgaard
@ 2025-06-12 20:10 ` Arnout Vandecappelle via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2025-06-12 20:10 UTC (permalink / raw)
  To: Julien Olivain, buildroot; +Cc: Thomas Bonnefille



On 08/06/2025 13:09, Julien Olivain wrote:
> Commit [1] "package/gstreamer1/gst1-plugins-bad: bump version
> to 1.24.11" added new requirements for webrtc which selects the
> sctp plugin, but forgot to propagate its dependencies. The sctp
> plugin depends on BR2_TOOLCHAIN_HAS_SYNC_4.
> 
> This commit fixes this issue.
> 
> Fixes:
> 
>      WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SCTP
>        Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BAD [=y] && BR2_TOOLCHAIN_HAS_SYNC_4 [=n]
>        Selected by [y]:
>        - BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC [=y] && BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BAD [=y] && !BR2_STATIC_LIBS [=n]
> 
> [1] https://gitlab.com/buildroot.org/buildroot/-/commit/90b3cfedf44cc92289746aa30e439be409ca3747
> 
> Cc: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> Signed-off-by: Julien Olivain <ju.o@free.fr>

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> ---
>   package/gstreamer1/gst1-plugins-bad/Config.in | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
> index 4c4e993714..89db860f87 100644
> --- a/package/gstreamer1/gst1-plugins-bad/Config.in
> +++ b/package/gstreamer1/gst1-plugins-bad/Config.in
> @@ -659,6 +659,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBP
>   config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC
>   	bool "webrtc"
>   	depends on !BR2_STATIC_LIBS # libnice -> gnutls
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # gst1-plugins-bad sctp
>   	select BR2_PACKAGE_GST1_PLUGINS_BASE # libgstsdp
>   	select BR2_PACKAGE_LIBNICE
>   	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DTLS
> @@ -669,6 +670,7 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTC
>   
>   comment "webrtc needs a toolchain w/ dynamic library"
>   	depends on BR2_STATIC_LIBS
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>   
>   config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_WEBRTCDSP
>   	bool "webrtcdsp"

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-06-12 20:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-08 11:09 [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-bad: webrtc needs sync_4 Julien Olivain
2025-06-09 14:22 ` Peter Korsgaard
2025-06-12 20:10 ` Arnout Vandecappelle via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.