Re: [PATCH v1 3/3] rust: time: add ktime_get() to ClockSource trait

[Andreas Hindborg <a.hindborg@kernel.org>]

"FUJITA Tomonori" <fujita.tomonori@gmail.com> writes:

> Introduce the ktime_get() associated function to the ClockSource
> trait, allowing each clock source to specify how it retrieves the
> current time. This enables Instant::now() to be implemented
> generically using the type-level ClockSource abstraction.
>
> This change enhances the type safety and extensibility of timekeeping
> by statically associating time retrieval mechanisms with their
> respective clock types. It also reduces the reliance on hardcoded
> clock logic within Instant.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> ---
>  rust/helpers/time.c | 16 ++++++++++++++++
>  rust/kernel/time.rs | 32 ++++++++++++++++++++++++++++----
>  2 files changed, 44 insertions(+), 4 deletions(-)
>
> diff --git a/rust/helpers/time.c b/rust/helpers/time.c
> index 7ae64ad8141d..613475c529d4 100644
> --- a/rust/helpers/time.c
> +++ b/rust/helpers/time.c
> @@ -1,8 +1,24 @@
>  // SPDX-License-Identifier: GPL-2.0
>
>  #include <linux/delay.h>
> +#include <linux/timekeeping.h>
>
>  void rust_helper_fsleep(unsigned long usecs)
>  {
>  	fsleep(usecs);
>  }
> +
> +ktime_t rust_helper_ktime_get_real(void)
> +{
> +	return ktime_get_with_offset(TK_OFFS_REAL);
> +}
> +
> +ktime_t rust_helper_ktime_get_boottime(void)
> +{
> +	return ktime_get_with_offset(TK_OFFS_BOOT);
> +}
> +
> +ktime_t rust_helper_ktime_get_clocktai(void)
> +{
> +	return ktime_get_with_offset(TK_OFFS_TAI);
> +}
> diff --git a/rust/kernel/time.rs b/rust/kernel/time.rs
> index db9a783631ec..4b9b61eed628 100644
> --- a/rust/kernel/time.rs
> +++ b/rust/kernel/time.rs
> @@ -63,6 +63,11 @@ pub trait ClockSource {
>      ///
>      /// This constant corresponds to the C side `clockid_t` value.
>      const ID: bindings::clockid_t;
> +
> +    /// Get the current time fro the clock source.

Typo fro -> from.


Reviewed-by: Andreas Hindborg <a.hindborg@kernel.org>


Best regards,
Andreas Hindborg