From: Andreas Hindborg <a.hindborg@kernel.org>
To: "FUJITA Tomonori" <fujita.tomonori@gmail.com>
Cc: <rust-for-linux@vger.kernel.org>, <boqun.feng@gmail.com>,
<ojeda@kernel.org>, <alex.gaynor@gmail.com>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <benno.lossin@proton.me>,
<aliceryhl@google.com>, <tmgross@umich.edu>, <dakr@kernel.org>,
<frederic@kernel.org>, <lyude@redhat.com>, <tglx@linutronix.de>,
<anna-maria@linutronix.de>, <jstultz@google.com>,
<sboyd@kernel.org>
Subject: Re: [PATCH v1 2/3] rust: time: make Instant generic over ClockSource
Date: Tue, 22 Apr 2025 15:11:29 +0200 [thread overview]
Message-ID: <87jz7c9w8u.fsf@kernel.org> (raw)
In-Reply-To: <20250413105629.162349-3-fujita.tomonori@gmail.com> (FUJITA Tomonori's message of "Sun, 13 Apr 2025 19:56:27 +0900")
"FUJITA Tomonori" <fujita.tomonori@gmail.com> writes:
> Refactor the Instant type to be generic over a ClockSource type
> parameter, enabling static enforcement of clock correctness across
> APIs that deal with time. Previously, the clock source was implicitly
> fixed (typically CLOCK_MONOTONIC), and developers had to ensure
> compatibility manually.
>
> This design eliminates runtime mismatches between clock sources, and
> enables stronger type-level guarantees throughout the timer subsystem.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
I think this patch will allow creating an `HrTimer` with one
`CockSource` and starting it with an instant that uses another
`ClockSource`. There is nothing tying the generic `U` in `HrTimer::new`
to the generic `C` in `HrTimerPointer`, right?
Best regards,
Andreas Hindborg
next prev parent reply other threads:[~2025-04-22 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-13 10:56 [PATCH v1 0/3] rust: time: Introduce typed clock sources and generalize Instant FUJITA Tomonori
2025-04-13 10:56 ` [PATCH v1 1/3] rust: time: replace ClockId enum with ClockSource trait FUJITA Tomonori
2025-04-22 12:51 ` Andreas Hindborg
2025-04-13 10:56 ` [PATCH v1 2/3] rust: time: make Instant generic over ClockSource FUJITA Tomonori
2025-04-22 13:11 ` Andreas Hindborg [this message]
2025-04-22 22:12 ` FUJITA Tomonori
2025-04-13 10:56 ` [PATCH v1 3/3] rust: time: add ktime_get() to ClockSource trait FUJITA Tomonori
2025-04-22 13:14 ` Andreas Hindborg
2025-04-22 22:47 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz7c9w8u.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.