All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: Dmitry Frolov <frolov@swemel.ru>, lvivier@redhat.com
Cc: sdl.qemu@linuxtesting.org, qemu-devel@nongnu.org,
	Dmitry Frolov <frolov@swemel.ru>
Subject: Re: [PATCH] tests/qtest: increase timeouts
Date: Tue, 12 Nov 2024 09:58:04 -0300	[thread overview]
Message-ID: <87ed3gip7n.fsf@suse.de> (raw)
In-Reply-To: <20241112120100.176492-2-frolov@swemel.ru>

Dmitry Frolov <frolov@swemel.ru> writes:

> More time for some tests needed when qemu is built with
> "--enable-asan --enable-ubsan"
>
> Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
> ---
>  tests/qtest/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index aa93e98418..ead2207f9c 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -5,7 +5,7 @@ slow_qtests = {
>    'cdrom-test' : 610,
>    'device-introspect-test' : 720,
>    'ide-test' : 120,
> -  'migration-test' : 480,
> +  'migration-test' : 600,
>    'npcm7xx_pwm-test': 300,
>    'npcm7xx_watchdog_timer-test': 120,
>    'qmp-cmd-test' : 120,
> @@ -15,7 +15,7 @@ slow_qtests = {
>    'pxe-test': 610,
>    'prom-env-test': 360,
>    'boot-serial-test': 360,
> -  'qos-test': 120,
> +  'qos-test': 240,
>    'vmgenid-test': 610,
>  }

I'm not sure this is the right change to make. In my machine a different
set of tests times out when using asan. Besides, the timeouts are mostly
tailored for the CI environment.

Would it be possible to check whether the build has asan enabled and
just use a global timeout? I'm afraid tweaking individual tests timeouts
will hide real slowness issues when not using asan.


  reply	other threads:[~2024-11-12 12:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 12:00 [PATCH] tests/qtest: increase timeouts Dmitry Frolov
2024-11-12 12:58 ` Fabiano Rosas [this message]
2024-11-12 13:05   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed3gip7n.fsf@suse.de \
    --to=farosas@suse.de \
    --cc=frolov@swemel.ru \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sdl.qemu@linuxtesting.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.