[PATCH] tests/qtest: increase timeouts

[PATCH] tests/qtest: increase timeouts

[Dmitry Frolov]

More time for some tests needed when qemu is built with
"--enable-asan --enable-ubsan"

Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
---
 tests/qtest/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index aa93e98418..ead2207f9c 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -5,7 +5,7 @@ slow_qtests = {
   'cdrom-test' : 610,
   'device-introspect-test' : 720,
   'ide-test' : 120,
-  'migration-test' : 480,
+  'migration-test' : 600,
   'npcm7xx_pwm-test': 300,
   'npcm7xx_watchdog_timer-test': 120,
   'qmp-cmd-test' : 120,
@@ -15,7 +15,7 @@ slow_qtests = {
   'pxe-test': 610,
   'prom-env-test': 360,
   'boot-serial-test': 360,
-  'qos-test': 120,
+  'qos-test': 240,
   'vmgenid-test': 610,
 }
 
-- 
2.43.0

Re: [PATCH] tests/qtest: increase timeouts

[Fabiano Rosas]

Dmitry Frolov <frolov@swemel.ru> writes:

> More time for some tests needed when qemu is built with
> "--enable-asan --enable-ubsan"
>
> Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
> ---
>  tests/qtest/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index aa93e98418..ead2207f9c 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -5,7 +5,7 @@ slow_qtests = {
>    'cdrom-test' : 610,
>    'device-introspect-test' : 720,
>    'ide-test' : 120,
> -  'migration-test' : 480,
> +  'migration-test' : 600,
>    'npcm7xx_pwm-test': 300,
>    'npcm7xx_watchdog_timer-test': 120,
>    'qmp-cmd-test' : 120,
> @@ -15,7 +15,7 @@ slow_qtests = {
>    'pxe-test': 610,
>    'prom-env-test': 360,
>    'boot-serial-test': 360,
> -  'qos-test': 120,
> +  'qos-test': 240,
>    'vmgenid-test': 610,
>  }

I'm not sure this is the right change to make. In my machine a different
set of tests times out when using asan. Besides, the timeouts are mostly
tailored for the CI environment.

Would it be possible to check whether the build has asan enabled and
just use a global timeout? I'm afraid tweaking individual tests timeouts
will hide real slowness issues when not using asan.

Re: [PATCH] tests/qtest: increase timeouts

[Daniel P. Berrangé]

On Tue, Nov 12, 2024 at 09:58:04AM -0300, Fabiano Rosas wrote:
> Dmitry Frolov <frolov@swemel.ru> writes:
> 
> > More time for some tests needed when qemu is built with
> > "--enable-asan --enable-ubsan"
> >
> > Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
> > ---
> >  tests/qtest/meson.build | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> > index aa93e98418..ead2207f9c 100644
> > --- a/tests/qtest/meson.build
> > +++ b/tests/qtest/meson.build
> > @@ -5,7 +5,7 @@ slow_qtests = {
> >    'cdrom-test' : 610,
> >    'device-introspect-test' : 720,
> >    'ide-test' : 120,
> > -  'migration-test' : 480,
> > +  'migration-test' : 600,
> >    'npcm7xx_pwm-test': 300,
> >    'npcm7xx_watchdog_timer-test': 120,
> >    'qmp-cmd-test' : 120,
> > @@ -15,7 +15,7 @@ slow_qtests = {
> >    'pxe-test': 610,
> >    'prom-env-test': 360,
> >    'boot-serial-test': 360,
> > -  'qos-test': 120,
> > +  'qos-test': 240,
> >    'vmgenid-test': 610,
> >  }
> 
> I'm not sure this is the right change to make. In my machine a different
> set of tests times out when using asan. Besides, the timeouts are mostly
> tailored for the CI environment.
> 
> Would it be possible to check whether the build has asan enabled and
> just use a global timeout? I'm afraid tweaking individual tests timeouts
> will hide real slowness issues when not using asan.

meson has a concept of a "timeout multiplier", which defaults to 1.

Enabling build options that are known to make execution slow ought
to be made to increase the timeout multiplier, for global effect.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|