From: Jani Nikula <jani.nikula@intel.com>
To: Marc Gonzalez <mgonzalez@freebox.fr>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Arnaud Vrac <avrac@freebox.fr>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
Nathan Chancellor <nathan@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() with __maybe_unused
Date: Thu, 12 Sep 2024 14:15:17 +0300 [thread overview]
Message-ID: <87ed5pgm2i.fsf@intel.com> (raw)
In-Reply-To: <9028f858-8c6d-4292-a6aa-27eedff3ac8b@freebox.fr>
On Thu, 12 Sep 2024, Marc Gonzalez <mgonzalez@freebox.fr> wrote:
> On 11/09/2024 12:23, Jani Nikula wrote:
>> On Tue, 10 Sep 2024, Marc Gonzalez <mgonzalez@freebox.fr> wrote:
>>> On 10/09/2024 16:51, Dmitry Baryshkov wrote:
>>>> On Tue, Sep 10, 2024 at 01:03:43PM GMT, Jani Nikula wrote:
>>>>> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
>>>>> inline functions for W=1 build").
[snip]
>> GCC doesn't catch unused static inlines, while Clang does.
>
> It makes no sense to me that adding "inline" would prevent
> GCC from diagnosing the issue... GCC should simply ignore
> the "inline" keyword when definition is not in a header file
> (maybe they don't store "origin").
Please just read the commit message for the commit I reference above for
details. There's not much more I could say about it.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-09-12 11:15 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 10:03 [PATCH 0/8] drm: fix and enable warnings on unused static inlines Jani Nikula
2024-09-10 10:03 ` [PATCH 1/8] drm/bridge: dw-hdmi-i2s: annotate hdmi_read() with __maybe_unused Jani Nikula
2024-09-10 10:03 ` [PATCH 2/8] drm: renesas: rcar-du: annotate rcar_cmm_read() " Jani Nikula
2024-09-10 12:39 ` Geert Uytterhoeven
2024-09-10 13:36 ` Jani Nikula
2024-09-11 9:51 ` Laurent Pinchart
2024-09-11 10:21 ` Jani Nikula
2024-09-10 10:03 ` [PATCH 3/8] drm/kmb: annotate set_test_mode_src_osc_freq_target_{low, hi}_bits() " Jani Nikula
2024-09-10 18:11 ` [PATCH 3/8] drm/kmb: annotate set_test_mode_src_osc_freq_target_{low,hi}_bits() " Chrisanthus, Anitha
2024-09-13 11:46 ` Jani Nikula
2024-09-10 10:03 ` [PATCH 4/8] drm/bridge: ti-sn65dsi86: annotate ti_sn_pwm_pin_{request, release} " Jani Nikula
2024-09-10 22:57 ` Doug Anderson
2024-09-11 8:01 ` Jani Nikula
2024-09-11 20:07 ` Doug Anderson
2024-09-10 10:03 ` [PATCH 5/8] drm/imagination: annotate pvr_fw_version_packed() " Jani Nikula
2024-09-10 10:40 ` Matt Coster
2024-09-13 11:47 ` Jani Nikula
2024-09-10 10:03 ` [PATCH 6/8] drm/meson: dw-hdmi: annotate dw_hdmi_dwc_write_bits() " Jani Nikula
2024-09-10 10:03 ` Jani Nikula
2024-09-15 19:35 ` Martin Blumenstingl
2024-09-15 19:35 ` Martin Blumenstingl
2024-09-16 7:43 ` Jani Nikula
2024-09-16 7:43 ` Jani Nikula
2024-09-10 10:03 ` [PATCH 7/8] drm/msmi: annotate pll_cmp_to_fdata() " Jani Nikula
2024-09-10 14:51 ` Dmitry Baryshkov
2024-09-10 15:54 ` Marc Gonzalez
2024-09-11 10:23 ` Jani Nikula
2024-09-12 10:56 ` Marc Gonzalez
2024-09-12 11:15 ` Jani Nikula [this message]
2024-09-12 12:14 ` Marc Gonzalez
2024-09-12 12:28 ` Dmitry Baryshkov
2024-09-12 12:50 ` Marc Gonzalez
2024-09-12 13:05 ` Dmitry Baryshkov
2024-09-12 13:10 ` Jani Nikula
2024-09-21 21:16 ` Dmitry Baryshkov
2024-09-23 6:38 ` Jani Nikula
2024-09-10 10:03 ` [PATCH 8/8] drm: enable warnings on unused static inlines Jani Nikula
2024-09-10 11:13 ` ✓ CI.Patch_applied: success for drm: fix and " Patchwork
2024-09-10 11:14 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-10 11:15 ` ✓ CI.KUnit: success " Patchwork
2024-09-10 11:37 ` ✓ CI.Build: " Patchwork
2024-09-10 11:40 ` ✓ CI.Hooks: " Patchwork
2024-09-10 11:41 ` ✗ CI.checksparse: warning " Patchwork
2024-09-10 12:30 ` ✓ CI.BAT: success " Patchwork
2024-09-10 13:37 ` ✗ CI.FULL: failure " Patchwork
2024-09-10 14:24 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-09-10 14:24 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-10 14:33 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-11 7:34 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-09-11 17:46 ` [PATCH 0/8] " Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed5pgm2i.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=avrac@freebox.fr \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mgonzalez@freebox.fr \
--cc=nathan@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.