Re: [PATCH 4/8] drm/bridge: ti-sn65dsi86: annotate ti_sn_pwm_pin_{request, release} with __maybe_unused

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 10 Sep 2024, Doug Anderson <dianders@chromium.org> wrote:
> Hi,
>
> On Tue, Sep 10, 2024 at 3:04 AM Jani Nikula <jani.nikula@intel.com> wrote:
>>
>> Building with clang, W=1, CONFIG_PM=n and CONFIG_OF_GPIO=n leads to
>> warning about unused ti_sn_pwm_pin_request() and
>> ti_sn_pwm_pin_release(). Fix by annotating them with __maybe_unused.
>>
>> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
>> inline functions for W=1 build").
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> Cc: Douglas Anderson <dianders@chromium.org>
>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Robert Foss <rfoss@kernel.org>
>> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>> Cc: Jonas Karlman <jonas@kwiboo.se>
>> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
>> Cc: Nathan Chancellor <nathan@kernel.org>
>> ---
>>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> I'm happy to land this in drm-misc-next unless there are any extra
> dependencies. Let me know. In some sense I guess this could even be
> considered a "Fix", though I guess given the history of the compiler
> options that might be a bit of a stretch.

drm-misc-next is fine. Agree on not considering this a fix.

BR,
Jani.


-- 
Jani Nikula, Intel