All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/dp: Clear VSC SDP during post ddi disable routine
@ 2024-07-23  4:28 Suraj Kandpal
  2024-07-23  5:16 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 12+ messages in thread
From: Suraj Kandpal @ 2024-07-23  4:28 UTC (permalink / raw)
  To: intel-gfx; +Cc: ankit.k.nautiyal, Suraj Kandpal

Clear VSC SDP if intel_dp_set_infoframes is called from post ddi disable
routine i.e with the variable of enable as false. This is to avoid
an infoframes.enable mismatch issue which is caused when pipe is
connected to eDp which has psr then connected to DPMST. In this case
eDp's post ddi disable routine does not clear infoframes.enable VSC
for the given pipe and DPMST does not recompute VSC SDP and write
infoframes.enable which causes a mismatch.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 1e43e32e0519..8b60d7f34ab8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4370,7 +4370,7 @@ void intel_dp_set_infoframes(struct intel_encoder *encoder,
 		val &= ~VDIP_ENABLE_PPS;
 
 	/* When PSR is enabled, this routine doesn't disable VSC DIP */
-	if (!crtc_state->has_psr)
+	if (!enable || !crtc_state->has_psr)
 		val &= ~VIDEO_DIP_ENABLE_VSC_HSW;
 
 	intel_de_write(dev_priv, reg, val);
-- 
2.43.2


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-07-25 23:31 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-23  4:28 [PATCH] drm/i915/dp: Clear VSC SDP during post ddi disable routine Suraj Kandpal
2024-07-23  5:16 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-07-23 15:12 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-07-24  6:10 ` [PATCH] " Nautiyal, Ankit K
2024-07-24 15:18   ` Jani Nikula
2024-07-24 16:37 ` Suraj Kandpal
2024-07-25  9:46   ` Kandpal, Suraj
2024-07-24 17:48 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: Clear VSC SDP during post ddi disable routine (rev2) Patchwork
2024-07-25  9:04 ` Patchwork
2024-07-25  9:06 ` ✓ Fi.CI.BAT: success " Patchwork
2024-07-25 23:24 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-07-25 23:31 ` Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.