* Re: [PATCH v3 1/1] usb: informative message if no controller
2024-06-18 9:58 [PATCH v3 1/1] usb: informative message if no controller Heinrich Schuchardt
@ 2024-06-18 10:04 ` Dragan Simic
2024-06-18 17:40 ` Dragan Simic
2024-06-18 10:34 ` Caleb Connolly
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Dragan Simic @ 2024-06-18 10:04 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Marek Vasut, Tom Rini, Simon Glass, Bin Meng, Mattijs Korpershoek,
Fabrice Gasnier, u-boot
On 2024-06-18 11:58, Heinrich Schuchardt wrote:
> The message 'No working controllers found' provides no clue that this
> refers to USB controllers.
>
> Provide a message that refers to USB. Use log_info().
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Thanks for rerolling this patch. Looking good to me.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> ---
> v3:
> plural controllers
> v2:
> add 'found' at end of message
> keep printf
> ---
> drivers/usb/host/usb-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/usb-uclass.c
> b/drivers/usb/host/usb-uclass.c
> index a1cd0ad2d66..e16432a1516 100644
> --- a/drivers/usb/host/usb-uclass.c
> +++ b/drivers/usb/host/usb-uclass.c
> @@ -388,7 +388,7 @@ int usb_init(void)
>
> /* if we were not able to find at least one working bus, bail out */
> if (controllers_initialized == 0)
> - printf("No working controllers found\n");
> + printf("No USB controllers found\n");
>
> return usb_started ? 0 : -ENOENT;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/1] usb: informative message if no controller
2024-06-18 10:04 ` Dragan Simic
@ 2024-06-18 17:40 ` Dragan Simic
0 siblings, 0 replies; 6+ messages in thread
From: Dragan Simic @ 2024-06-18 17:40 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Marek Vasut, Tom Rini, Simon Glass, Bin Meng, Mattijs Korpershoek,
Fabrice Gasnier, u-boot
On 2024-06-18 12:04, Dragan Simic wrote:
> On 2024-06-18 11:58, Heinrich Schuchardt wrote:
>> The message 'No working controllers found' provides no clue that this
>> refers to USB controllers.
>>
>> Provide a message that refers to USB. Use log_info().
Huh, I missed the "use log_info()" part. The patch description should
be adjusted not to mention it, and there should be another patch that
switches printf() to log_info().
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>
> Thanks for rerolling this patch. Looking good to me.
>
> Reviewed-by: Dragan Simic <dsimic@manjaro.org>
>
>> ---
>> v3:
>> plural controllers
>> v2:
>> add 'found' at end of message
>> keep printf
>> ---
>> drivers/usb/host/usb-uclass.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/usb-uclass.c
>> b/drivers/usb/host/usb-uclass.c
>> index a1cd0ad2d66..e16432a1516 100644
>> --- a/drivers/usb/host/usb-uclass.c
>> +++ b/drivers/usb/host/usb-uclass.c
>> @@ -388,7 +388,7 @@ int usb_init(void)
>>
>> /* if we were not able to find at least one working bus, bail out */
>> if (controllers_initialized == 0)
>> - printf("No working controllers found\n");
>> + printf("No USB controllers found\n");
>>
>> return usb_started ? 0 : -ENOENT;
>> }
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/1] usb: informative message if no controller
2024-06-18 9:58 [PATCH v3 1/1] usb: informative message if no controller Heinrich Schuchardt
2024-06-18 10:04 ` Dragan Simic
@ 2024-06-18 10:34 ` Caleb Connolly
2024-06-18 11:50 ` Marek Vasut
2024-06-18 12:04 ` Mattijs Korpershoek
3 siblings, 0 replies; 6+ messages in thread
From: Caleb Connolly @ 2024-06-18 10:34 UTC (permalink / raw)
To: Heinrich Schuchardt, Marek Vasut
Cc: Tom Rini, Simon Glass, Bin Meng, Mattijs Korpershoek,
Fabrice Gasnier, Dragan Simic, u-boot
On 18/06/2024 11:58, Heinrich Schuchardt wrote:
> The message 'No working controllers found' provides no clue that this
> refers to USB controllers.
>
> Provide a message that refers to USB. Use log_info().
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
> v3:
> plural controllers
> v2:
> add 'found' at end of message
> keep printf
> ---
> drivers/usb/host/usb-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c
> index a1cd0ad2d66..e16432a1516 100644
> --- a/drivers/usb/host/usb-uclass.c
> +++ b/drivers/usb/host/usb-uclass.c
> @@ -388,7 +388,7 @@ int usb_init(void)
>
> /* if we were not able to find at least one working bus, bail out */
> if (controllers_initialized == 0)
> - printf("No working controllers found\n");
> + printf("No USB controllers found\n");
>
> return usb_started ? 0 : -ENOENT;
> }
--
// Caleb (they/them)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/1] usb: informative message if no controller
2024-06-18 9:58 [PATCH v3 1/1] usb: informative message if no controller Heinrich Schuchardt
2024-06-18 10:04 ` Dragan Simic
2024-06-18 10:34 ` Caleb Connolly
@ 2024-06-18 11:50 ` Marek Vasut
2024-06-18 12:04 ` Mattijs Korpershoek
3 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2024-06-18 11:50 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Tom Rini, Simon Glass, Bin Meng, Mattijs Korpershoek,
Fabrice Gasnier, Dragan Simic, u-boot
On 6/18/24 11:58 AM, Heinrich Schuchardt wrote:
> The message 'No working controllers found' provides no clue that this
> refers to USB controllers.
>
> Provide a message that refers to USB. Use log_info().
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Marek Vasut <marex@denx.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/1] usb: informative message if no controller
2024-06-18 9:58 [PATCH v3 1/1] usb: informative message if no controller Heinrich Schuchardt
` (2 preceding siblings ...)
2024-06-18 11:50 ` Marek Vasut
@ 2024-06-18 12:04 ` Mattijs Korpershoek
3 siblings, 0 replies; 6+ messages in thread
From: Mattijs Korpershoek @ 2024-06-18 12:04 UTC (permalink / raw)
To: Heinrich Schuchardt, Marek Vasut
Cc: Tom Rini, Simon Glass, Bin Meng, Fabrice Gasnier, Dragan Simic,
u-boot, Heinrich Schuchardt
Hi Heinrich,
Thank you for the patch.
On mar., juin 18, 2024 at 11:58, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
> The message 'No working controllers found' provides no clue that this
> refers to USB controllers.
>
> Provide a message that refers to USB. Use log_info().
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
> v3:
> plural controllers
> v2:
> add 'found' at end of message
> keep printf
> ---
> drivers/usb/host/usb-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c
> index a1cd0ad2d66..e16432a1516 100644
> --- a/drivers/usb/host/usb-uclass.c
> +++ b/drivers/usb/host/usb-uclass.c
> @@ -388,7 +388,7 @@ int usb_init(void)
>
> /* if we were not able to find at least one working bus, bail out */
> if (controllers_initialized == 0)
> - printf("No working controllers found\n");
> + printf("No USB controllers found\n");
>
> return usb_started ? 0 : -ENOENT;
> }
> --
> 2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread