From: Peter Korsgaard <peter@korsgaard.com>
To: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit] support/download/check-hash: fix shellcheck errors
Date: Sun, 28 Apr 2024 21:46:11 +0200 [thread overview]
Message-ID: <87edapb798.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240401184812.E9A6184735@busybox.osuosl.org> (Yann E. MORIN's message of "Mon, 1 Apr 2024 17:03:17 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=9cb421c16f9aa026eabe050d94664c137f93eff5
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> The hash files do not use trailing backslash \ to continue lines, so
> we don't want them to be interpreted thusly, so we use 'read -r'
> (SC2162).
> The h_file is used twice in the same loop, once for reading from it,
> and once just to print it, so there is no conflict (SC2094).
> Integrer variables need not be quoted (SC2086). In any case, should
> there be an actual issue and they be set empty, that would cause a
> runtime issue, wether they be quoted or not.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-04-28 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 15:03 [Buildroot] [git commit] support/download/check-hash: fix shellcheck errors Yann E. MORIN
2024-04-28 19:46 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edapb798.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.