All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Nianyao Tang <tangnianyao@huawei.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: <yuzenghui@huawei.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <guoyang2@huawei.com>,
	<wangwudi@hisilicon.com>
Subject: Re: [RESPIN PATCH] irqchip/gic-v4.1:Fix VSYNC referencing an unmapped VPE
Date: Sat, 06 Apr 2024 10:58:10 +0100	[thread overview]
Message-ID: <87edbisthp.wl-maz@kernel.org> (raw)
In-Reply-To: <20240406022737.3898763-1-tangnianyao@huawei.com>

On Sat, 06 Apr 2024 03:27:37 +0100,
Nianyao Tang <tangnianyao@huawei.com> wrote:
> 
> As per the GICv4.1 spec (Arm IHI 0069H, 5.3.19):
> 
> "A VMAPP with {V, Alloc}=={0, x} is self-synchronizing, This means the
> ITS command queue does not show the command as consumed until all of
> its effects are completed."
> 
> Furthermore, VSYNC is allowed to deliver an SError when referencing a
> non existent VPE.
> 
> By these definitions, a VMAPP followed by a VSYNC is a bug, as the
> later references a VPE that has been unmapped by the former.
> 
> Fix it by eliding the VSYNC in this scenario.
> 
> Fixes: 64edfaa9a234 ("irqchip/gic-v4.1: Implement the v4.1 flavour of VMAPP")
> 
> Signed-off-by: Nianyao Tang <tangnianyao@huawei.com>
> Reviewed-by: Marc Zyngier <maz@kernel.org>

Thanks for having taken my remarks into account, it looks good now.

Thomas, can you please take this as a fix for 6.9?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Nianyao Tang <tangnianyao@huawei.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: <yuzenghui@huawei.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <guoyang2@huawei.com>,
	<wangwudi@hisilicon.com>
Subject: Re: [RESPIN PATCH] irqchip/gic-v4.1:Fix VSYNC referencing an unmapped VPE
Date: Sat, 06 Apr 2024 10:58:10 +0100	[thread overview]
Message-ID: <87edbisthp.wl-maz@kernel.org> (raw)
In-Reply-To: <20240406022737.3898763-1-tangnianyao@huawei.com>

On Sat, 06 Apr 2024 03:27:37 +0100,
Nianyao Tang <tangnianyao@huawei.com> wrote:
> 
> As per the GICv4.1 spec (Arm IHI 0069H, 5.3.19):
> 
> "A VMAPP with {V, Alloc}=={0, x} is self-synchronizing, This means the
> ITS command queue does not show the command as consumed until all of
> its effects are completed."
> 
> Furthermore, VSYNC is allowed to deliver an SError when referencing a
> non existent VPE.
> 
> By these definitions, a VMAPP followed by a VSYNC is a bug, as the
> later references a VPE that has been unmapped by the former.
> 
> Fix it by eliding the VSYNC in this scenario.
> 
> Fixes: 64edfaa9a234 ("irqchip/gic-v4.1: Implement the v4.1 flavour of VMAPP")
> 
> Signed-off-by: Nianyao Tang <tangnianyao@huawei.com>
> Reviewed-by: Marc Zyngier <maz@kernel.org>

Thanks for having taken my remarks into account, it looks good now.

Thomas, can you please take this as a fix for 6.9?

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2024-04-06  9:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-06  2:27 [RESPIN PATCH] irqchip/gic-v4.1:Fix VSYNC referencing an unmapped VPE Nianyao Tang
2024-04-06  2:27 ` Nianyao Tang
2024-04-06  9:58 ` Marc Zyngier [this message]
2024-04-06  9:58   ` Marc Zyngier
2024-04-07  3:40 ` Zenghui Yu
2024-04-07  3:40   ` Zenghui Yu
2024-04-09  9:16 ` [tip: irq/urgent] irqchip/gic-v3-its: Fix VSYNC referencing an unmapped VPE on GIC v4.1 tip-bot2 for Nianyao Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edbisthp.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=guoyang2@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tangnianyao@huawei.com \
    --cc=tglx@linutronix.de \
    --cc=wangwudi@hisilicon.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.