* [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST @ 2024-02-01 9:46 Ivan Orlov 2024-02-01 13:05 ` Takashi Iwai 0 siblings, 1 reply; 3+ messages in thread From: Ivan Orlov @ 2024-02-01 9:46 UTC (permalink / raw) To: perex, tiwai; +Cc: Ivan Orlov, linux-sound, linux-kernel Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry as the test uses symbols from 'pcm_misc.c'. Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com> --- sound/core/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/core/Kconfig b/sound/core/Kconfig index 664c6ee2b5a1..9a44f259ccca 100644 --- a/sound/core/Kconfig +++ b/sound/core/Kconfig @@ -42,6 +42,7 @@ config SND_UMP_LEGACY_RAWMIDI config SND_CORE_TEST tristate "Sound core KUnit test" depends on KUNIT + depends on SND_PCM default KUNIT_ALL_TESTS help This options enables the sound core functions KUnit test. -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST 2024-02-01 9:46 [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST Ivan Orlov @ 2024-02-01 13:05 ` Takashi Iwai 2024-02-01 21:48 ` Ivan Orlov 0 siblings, 1 reply; 3+ messages in thread From: Takashi Iwai @ 2024-02-01 13:05 UTC (permalink / raw) To: Ivan Orlov; +Cc: perex, tiwai, linux-sound, linux-kernel On Thu, 01 Feb 2024 10:46:04 +0100, Ivan Orlov wrote: > > Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry > as the test uses symbols from 'pcm_misc.c'. > > Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com> It should rather select instead of depends-on. User can't enable CONFIG_SND_PCM explicitly, but it's selected by the top-level drivers. Also, please add Fixes tag. It's a clear regression fix. thanks, Takashi ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST 2024-02-01 13:05 ` Takashi Iwai @ 2024-02-01 21:48 ` Ivan Orlov 0 siblings, 0 replies; 3+ messages in thread From: Ivan Orlov @ 2024-02-01 21:48 UTC (permalink / raw) To: Takashi Iwai; +Cc: perex, tiwai, linux-sound, linux-kernel On 2/1/24 13:05, Takashi Iwai wrote: > > It should rather select instead of depends-on. User can't enable > CONFIG_SND_PCM explicitly, but it's selected by the top-level > drivers. > > Also, please add Fixes tag. It's a clear regression fix. > Alright, I'll send the V2 with suggested changes. Thank you for the review! -- Kind regards, Ivan Orlov ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-01 21:48 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-02-01 9:46 [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST Ivan Orlov 2024-02-01 13:05 ` Takashi Iwai 2024-02-01 21:48 ` Ivan Orlov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.