All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Eric Dumazet <edumazet@google.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226
Date: Thu, 25 Jan 2024 08:31:54 +0100	[thread overview]
Message-ID: <87ede5eumt.fsf@kurt.kurt.home> (raw)
In-Reply-To: <de659af0-807f-4176-a7c2-d8013d445f9e@lunn.ch>

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

On Wed Jan 24 2024, Andrew Lunn wrote:
> On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote:
>> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
>> from user space using the netdev trigger. The LEDs are named as
>> igc-<bus><device>-<led> to be easily identified.
>> 
>> Offloading activity and link speed is supported. Tested on Intel i225.
>
> Nice to see something not driver by phylib/DSA making use of LEDs.
>
> Is there no plain on/off support? Ideally we want that for software
> blinking for when a mode is not supported.

Plain on and off is supported is supported, too. Should be possible to
implement brightness_set().

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226
Date: Thu, 25 Jan 2024 08:31:54 +0100	[thread overview]
Message-ID: <87ede5eumt.fsf@kurt.kurt.home> (raw)
In-Reply-To: <de659af0-807f-4176-a7c2-d8013d445f9e@lunn.ch>

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

On Wed Jan 24 2024, Andrew Lunn wrote:
> On Wed, Jan 24, 2024 at 09:24:08AM +0100, Kurt Kanzenbach wrote:
>> Add support for LEDs on i225/i226. The LEDs can be controlled via sysfs
>> from user space using the netdev trigger. The LEDs are named as
>> igc-<bus><device>-<led> to be easily identified.
>> 
>> Offloading activity and link speed is supported. Tested on Intel i225.
>
> Nice to see something not driver by phylib/DSA making use of LEDs.
>
> Is there no plain on/off support? Ideally we want that for software
> blinking for when a mode is not supported.

Plain on and off is supported is supported, too. Should be possible to
implement brightness_set().

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2024-01-25  7:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  8:24 [Intel-wired-lan] [PATCH v1 iwl-next] igc: Add support for LEDs on i225/i226 Kurt Kanzenbach
2024-01-24  8:24 ` Kurt Kanzenbach
2024-01-24 21:08 ` [Intel-wired-lan] " Simon Horman
2024-01-24 21:08   ` Simon Horman
2024-01-25  7:20   ` [Intel-wired-lan] " Kurt Kanzenbach
2024-01-25  7:20     ` Kurt Kanzenbach
2024-01-25 11:53     ` [Intel-wired-lan] " Simon Horman
2024-01-25 11:53       ` Simon Horman
2024-01-24 21:52 ` [Intel-wired-lan] " Andrew Lunn
2024-01-24 21:52   ` Andrew Lunn
2024-01-25  7:31   ` Kurt Kanzenbach [this message]
2024-01-25  7:31     ` Kurt Kanzenbach
2024-01-25 16:47     ` [Intel-wired-lan] " Andrew Lunn
2024-01-25 16:47       ` Andrew Lunn
2024-01-26  8:37       ` [Intel-wired-lan] " Kurt Kanzenbach
2024-01-26  8:37         ` Kurt Kanzenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ede5eumt.fsf@kurt.kurt.home \
    --to=kurt@linutronix.de \
    --cc=andrew@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.