From: Marc Zyngier <maz@kernel.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: <tglx@linutronix.de>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3-its: BUG_ON if stall bit is set
Date: Thu, 07 Dec 2023 07:43:04 +0000 [thread overview]
Message-ID: <87edfy8nlj.wl-maz@kernel.org> (raw)
In-Reply-To: <1701929559-18252-1-git-send-email-quic_mojha@quicinc.com>
On Thu, 07 Dec 2023 06:12:39 +0000,
Mukesh Ojha <quic_mojha@quicinc.com> wrote:
>
> There could be various reason that stall bit could
> be set due to software errors while processing
> commands in command queue is being processed and
Such as?
> waiting for 1s is not going to help in debugging
> as command processing anyways going to be timed
> out and system will continue to run and may crash
> after some time due to this.
>
> So, to debug such issues what command caused the
> stall bit to set, BUG_ON right away.
How on Earth will killing the system allow *anything* to be further
debugged?
If you need debug information, add the correct debug statements using
pr_debug(). Even better, try to gracefully recover from it if the ITS
command queue supports restarting.
Crashing the system is not an option.
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: <tglx@linutronix.de>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3-its: BUG_ON if stall bit is set
Date: Thu, 07 Dec 2023 07:43:04 +0000 [thread overview]
Message-ID: <87edfy8nlj.wl-maz@kernel.org> (raw)
In-Reply-To: <1701929559-18252-1-git-send-email-quic_mojha@quicinc.com>
On Thu, 07 Dec 2023 06:12:39 +0000,
Mukesh Ojha <quic_mojha@quicinc.com> wrote:
>
> There could be various reason that stall bit could
> be set due to software errors while processing
> commands in command queue is being processed and
Such as?
> waiting for 1s is not going to help in debugging
> as command processing anyways going to be timed
> out and system will continue to run and may crash
> after some time due to this.
>
> So, to debug such issues what command caused the
> stall bit to set, BUG_ON right away.
How on Earth will killing the system allow *anything* to be further
debugged?
If you need debug information, add the correct debug statements using
pr_debug(). Even better, try to gracefully recover from it if the ITS
command queue supports restarting.
Crashing the system is not an option.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-12-07 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 6:12 [PATCH] irqchip/gic-v3-its: BUG_ON if stall bit is set Mukesh Ojha
2023-12-07 6:12 ` Mukesh Ojha
2023-12-07 7:43 ` Marc Zyngier [this message]
2023-12-07 7:43 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edfy8nlj.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.