All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org,  Peter Xu <peterx@redhat.com>,
	 Fabiano Rosas <farosas@suse.de>,
	 Markus Armbruster <armbru@redhat.com>,
	 Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH v2] migration/ram: Fix compilation with -Wshadow=local
Date: Tue, 24 Oct 2023 12:32:09 +0200	[thread overview]
Message-ID: <87edhk1fbq.fsf@secure.mitica> (raw)
In-Reply-To: <20231024092220.55305-1-thuth@redhat.com> (Thomas Huth's message of "Tue, 24 Oct 2023 11:22:20 +0200")

Thomas Huth <thuth@redhat.com> wrote:
> Rename the variable here to avoid that it shadows a variable from
> the beginning of the function scope. With this change the code now
> successfully compiles with -Wshadow=local.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

queued.

> ---
>  v2: Need the value for the qemu_file_set_error() line, too

I also hate qemu_file_set_error().

Direct translation of Spanish Saying:

Evil of many, consolation of fools

O:-)



  reply	other threads:[~2023-10-24 10:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24  9:22 [PATCH v2] migration/ram: Fix compilation with -Wshadow=local Thomas Huth
2023-10-24 10:32 ` Juan Quintela [this message]
2023-10-24 10:57   ` Markus Armbruster
2023-10-24 10:34 ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edhk1fbq.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=armbru@redhat.com \
    --cc=farosas@suse.de \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.