Re: [PATCH v2] migration/ram: Fix compilation with -Wshadow=local

[Markus Armbruster <armbru@redhat.com>]

Juan Quintela <quintela@redhat.com> writes:

> Thomas Huth <thuth@redhat.com> wrote:
>> Rename the variable here to avoid that it shadows a variable from
>> the beginning of the function scope. With this change the code now
>> successfully compiles with -Wshadow=local.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> queued.

I'm going to post a patch to enable -Wshadow=local, based on all the
outstanding shadow fixes, including this one.  When I do the PR for the
enabling patch, I'll need to include any outstanding shadow fixes.
Should be fine no matter how it races with your PR.

>> ---
>>  v2: Need the value for the qemu_file_set_error() line, too
>
> I also hate qemu_file_set_error().
>
> Direct translation of Spanish Saying:
>
> Evil of many, consolation of fools
>
> O:-)

Good one!