All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Rob Herring <robh@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-rockchip@lists.infradead.org,
	Johan Jonker <jbx6244@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property
Date: Tue, 20 Dec 2022 09:34:27 +0200	[thread overview]
Message-ID: <87edsua5q4.fsf@balbi.sh> (raw)
In-Reply-To: <20221219191038.1973807-1-robh@kernel.org>


[-- Attachment #1.1: Type: text/plain, Size: 1552 bytes --]


Hi,

Rob Herring <robh@kernel.org> writes:

> The Rockchip RK3399 DWC3 node has 'power-domain' property which isn't
> allowed by the schema:
>
> usb@fe900000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>
> Allow DWC3 nodes to have a single power-domains entry. We could instead
> move the power-domains property to the parent wrapper node, but the
> could be an ABI break (Linux shouldn't care). Also, we don't want to
> encourage the pattern of wrapper nodes just to define resources such as
> clocks, resets, power-domains, etc. when not necessary.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 6d78048c4613..bcefd1c2410a 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -91,6 +91,9 @@ properties:
>          - usb2-phy
>          - usb3-phy
>  
> +  power-domains:
> +    maxItems: 1

AFAICT this can be incorrect. Also, you could have Cc the dwc3
maintainer to get comments.

@Thinh, how many power rails does dwc3 need? I don't have access to a
databook anymore, but I have a vague memory that different parts of dwc3
could, potentially, be powered by completely separate supplies, no? Or
is that only the case for clock domains in dwc3?

-- 
balbi

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Rob Herring <robh@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-rockchip@lists.infradead.org,
	Johan Jonker <jbx6244@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property
Date: Tue, 20 Dec 2022 09:34:27 +0200	[thread overview]
Message-ID: <87edsua5q4.fsf@balbi.sh> (raw)
In-Reply-To: <20221219191038.1973807-1-robh@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]


Hi,

Rob Herring <robh@kernel.org> writes:

> The Rockchip RK3399 DWC3 node has 'power-domain' property which isn't
> allowed by the schema:
>
> usb@fe900000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>
> Allow DWC3 nodes to have a single power-domains entry. We could instead
> move the power-domains property to the parent wrapper node, but the
> could be an ABI break (Linux shouldn't care). Also, we don't want to
> encourage the pattern of wrapper nodes just to define resources such as
> clocks, resets, power-domains, etc. when not necessary.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 6d78048c4613..bcefd1c2410a 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -91,6 +91,9 @@ properties:
>          - usb2-phy
>          - usb3-phy
>  
> +  power-domains:
> +    maxItems: 1

AFAICT this can be incorrect. Also, you could have Cc the dwc3
maintainer to get comments.

@Thinh, how many power rails does dwc3 need? I don't have access to a
databook anymore, but I have a vague memory that different parts of dwc3
could, potentially, be powered by completely separate supplies, no? Or
is that only the case for clock domains in dwc3?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Rob Herring <robh@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-rockchip@lists.infradead.org,
	Johan Jonker <jbx6244@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property
Date: Tue, 20 Dec 2022 09:34:27 +0200	[thread overview]
Message-ID: <87edsua5q4.fsf@balbi.sh> (raw)
In-Reply-To: <20221219191038.1973807-1-robh@kernel.org>


[-- Attachment #1.1: Type: text/plain, Size: 1552 bytes --]


Hi,

Rob Herring <robh@kernel.org> writes:

> The Rockchip RK3399 DWC3 node has 'power-domain' property which isn't
> allowed by the schema:
>
> usb@fe900000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>
> Allow DWC3 nodes to have a single power-domains entry. We could instead
> move the power-domains property to the parent wrapper node, but the
> could be an ABI break (Linux shouldn't care). Also, we don't want to
> encourage the pattern of wrapper nodes just to define resources such as
> clocks, resets, power-domains, etc. when not necessary.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index 6d78048c4613..bcefd1c2410a 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -91,6 +91,9 @@ properties:
>          - usb2-phy
>          - usb3-phy
>  
> +  power-domains:
> +    maxItems: 1

AFAICT this can be incorrect. Also, you could have Cc the dwc3
maintainer to get comments.

@Thinh, how many power rails does dwc3 need? I don't have access to a
databook anymore, but I have a vague memory that different parts of dwc3
could, potentially, be powered by completely separate supplies, no? Or
is that only the case for clock domains in dwc3?

-- 
balbi

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-12-20  7:35 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 19:10 [PATCH 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property Rob Herring
2022-12-19 19:10 ` Rob Herring
2022-12-19 19:10 ` Rob Herring
2022-12-19 19:10 ` [PATCH 2/2] dt-bindings: usb: rockchip,dwc3: Move RK3399 to its own schema Rob Herring
2022-12-19 19:10   ` Rob Herring
2022-12-19 19:10   ` Rob Herring
2022-12-20  7:37   ` Felipe Balbi
2022-12-20  7:37     ` Felipe Balbi
2022-12-20  7:37     ` Felipe Balbi
2022-12-20 13:54     ` Rob Herring
2022-12-20 13:54       ` Rob Herring
2022-12-20 13:54       ` Rob Herring
2022-12-23 10:34       ` Felipe Balbi
2022-12-23 10:34         ` Felipe Balbi
2022-12-23 10:34         ` Felipe Balbi
2022-12-20  7:34 ` Felipe Balbi [this message]
2022-12-20  7:34   ` [PATCH 1/2] dt-bindings: usb: snps,dwc3: Allow power-domains property Felipe Balbi
2022-12-20  7:34   ` Felipe Balbi
2022-12-20 14:04   ` Rob Herring
2022-12-20 14:04     ` Rob Herring
2022-12-20 14:04     ` Rob Herring
2022-12-23 10:31     ` Felipe Balbi
2022-12-23 10:31       ` Felipe Balbi
2022-12-23 10:31       ` Felipe Balbi
2022-12-23 11:06       ` Krzysztof Kozlowski
2022-12-23 11:06         ` Krzysztof Kozlowski
2022-12-23 11:06         ` Krzysztof Kozlowski
2022-12-23 23:57       ` Thinh Nguyen
2022-12-23 23:57         ` Thinh Nguyen
2022-12-23 23:57         ` Thinh Nguyen
2022-12-24 17:37         ` Rob Herring
2022-12-24 17:37           ` Rob Herring
2022-12-24 17:37           ` Rob Herring
2022-12-30  8:43           ` Felipe Balbi
2022-12-30  8:43             ` Felipe Balbi
2022-12-30  8:43             ` Felipe Balbi
2022-12-30 16:54             ` Rob Herring
2022-12-30 16:54               ` Rob Herring
2022-12-30 16:54               ` Rob Herring
2022-12-30 17:08               ` Felipe Balbi
2022-12-30 17:08                 ` Felipe Balbi
2022-12-30 17:08                 ` Felipe Balbi
2023-01-03 18:58                 ` Rob Herring
2023-01-03 18:58                   ` Rob Herring
2023-01-03 18:58                   ` Rob Herring
2023-01-09 19:40                   ` Thinh Nguyen
2023-01-09 19:40                     ` Thinh Nguyen
2023-01-09 19:40                     ` Thinh Nguyen
2023-01-09 20:42                     ` Rob Herring
2023-01-09 20:42                       ` Rob Herring
2023-01-09 20:42                       ` Rob Herring
2023-01-09 21:37                       ` Thinh Nguyen
2023-01-09 21:37                         ` Thinh Nguyen
2023-01-09 21:37                         ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edsua5q4.fsf@balbi.sh \
    --to=balbi@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.