[REGRESSION v6.1-rc1] rtc: cmos: rtcwake broken on NUC8i7HVK

[Kalle Valo <kvalo@kernel.org>]

Hi Rafael and Alexandre,

I upgraded my NUC8i7HVK test box to v6.1-rc1 and noticed that my suspend
tests with ath11k were broken, the box never woke up from suspend
automatically and I had to manually push the power button to trigger
resume. This is the command I used:

sudo rtcwake -m mem -s 30

v6.0 works without problems and a bisect found this commit:

commit 4919d3eb2ec0ee364f7e3cf2d99646c1b224fae8
Author:     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
AuthorDate: Wed Oct 12 20:07:01 2022 +0200
Commit:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CommitDate: Thu Oct 13 23:27:52 2022 +0200

    rtc: cmos: Fix event handler registration ordering issue

And indeed reverting that commit fixed the issue and suspend works as
before. Here's some info about my hardware:

$ dmesg | grep rtc
[   10.884460] rtc_cmos 00:03: RTC can wake from S4
[   10.888439] rtc_cmos 00:03: registered as rtc0
[   10.888930] rtc_cmos 00:03: alarms up to one month, y3k, 242 bytes nvram

$ lshw
nuc2
    description: Desktop Computer
    product: NUC8i7HVK
    vendor: Intel(R) Client Systems
    version: J71485-504
[...]
     *-cpu
          description: CPU
          product: Intel(R) Core(TM) i7-8809G CPU @ 3.10GHz
[...]
     *-pnp00:03
          product: PnP device PNP0b00
          physical id: 4
          capabilities: pnp
          configuration: driver=rtc_cmos

Do let me know if more info is needed, I can also test patches. But next
week I'm travelling and do not have access to the box.

Kalle