[REGRESSION v6.1-rc1] rtc: cmos: rtcwake broken on NUC8i7HVK

[REGRESSION v6.1-rc1] rtc: cmos: rtcwake broken on NUC8i7HVK

[Kalle Valo]

Hi Rafael and Alexandre,

I upgraded my NUC8i7HVK test box to v6.1-rc1 and noticed that my suspend
tests with ath11k were broken, the box never woke up from suspend
automatically and I had to manually push the power button to trigger
resume. This is the command I used:

sudo rtcwake -m mem -s 30

v6.0 works without problems and a bisect found this commit:

commit 4919d3eb2ec0ee364f7e3cf2d99646c1b224fae8
Author:     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
AuthorDate: Wed Oct 12 20:07:01 2022 +0200
Commit:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CommitDate: Thu Oct 13 23:27:52 2022 +0200

    rtc: cmos: Fix event handler registration ordering issue

And indeed reverting that commit fixed the issue and suspend works as
before. Here's some info about my hardware:

$ dmesg | grep rtc
[   10.884460] rtc_cmos 00:03: RTC can wake from S4
[   10.888439] rtc_cmos 00:03: registered as rtc0
[   10.888930] rtc_cmos 00:03: alarms up to one month, y3k, 242 bytes nvram

$ lshw
nuc2
    description: Desktop Computer
    product: NUC8i7HVK
    vendor: Intel(R) Client Systems
    version: J71485-504
[...]
     *-cpu
          description: CPU
          product: Intel(R) Core(TM) i7-8809G CPU @ 3.10GHz
[...]
     *-pnp00:03
          product: PnP device PNP0b00
          physical id: 4
          capabilities: pnp
          configuration: driver=rtc_cmos

Do let me know if more info is needed, I can also test patches. But next
week I'm travelling and do not have access to the box.

Kalle

Re: [REGRESSION v6.1-rc1] rtc: cmos: rtcwake broken on NUC8i7HVK

[Thorsten Leemhuis]

Hi, this is your Linux kernel regression tracker.

On 17.10.22 18:58, Kalle Valo wrote:
> 
> I upgraded my NUC8i7HVK test box to v6.1-rc1 and noticed that my suspend
> tests with ath11k were broken, the box never woke up from suspend
> automatically and I had to manually push the power button to trigger
> resume. This is the command I used:
> 
> sudo rtcwake -m mem -s 30
> 
> v6.0 works without problems and a bisect found this commit:
> 
> commit 4919d3eb2ec0ee364f7e3cf2d99646c1b224fae8
> Author:     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> AuthorDate: Wed Oct 12 20:07:01 2022 +0200
> Commit:     Alexandre Belloni <alexandre.belloni@bootlin.com>
> CommitDate: Thu Oct 13 23:27:52 2022 +0200
> 
>     rtc: cmos: Fix event handler registration ordering issue

FWIW, Todd also reported this yesterday:
https://lore.kernel.org/all/967cfe4e2dba242352ccd1cd00bdbcfb48bdd697.camel@linux.intel.com/
https://bugzilla.kernel.org/show_bug.cgi?id=216600

And Zhang Rui provided a patch in bugzilla that should fix this.

HTH, Ciao, Thorsten

> And indeed reverting that commit fixed the issue and suspend works as
> before. Here's some info about my hardware:
> 
> $ dmesg | grep rtc
> [   10.884460] rtc_cmos 00:03: RTC can wake from S4
> [   10.888439] rtc_cmos 00:03: registered as rtc0
> [   10.888930] rtc_cmos 00:03: alarms up to one month, y3k, 242 bytes nvram
> 
> $ lshw
> nuc2
>     description: Desktop Computer
>     product: NUC8i7HVK
>     vendor: Intel(R) Client Systems
>     version: J71485-504
> [...]
>      *-cpu
>           description: CPU
>           product: Intel(R) Core(TM) i7-8809G CPU @ 3.10GHz
> [...]
>      *-pnp00:03
>           product: PnP device PNP0b00
>           physical id: 4
>           capabilities: pnp
>           configuration: driver=rtc_cmos
> 
> Do let me know if more info is needed, I can also test patches. But next
> week I'm travelling and do not have access to the box.
> 
> Kalle
> 
> 

Re: [REGRESSION v6.1-rc1] rtc: cmos: rtcwake broken on NUC8i7HVK

[Kalle Valo]

Thorsten Leemhuis <regressions@leemhuis.info> writes:

> On 17.10.22 18:58, Kalle Valo wrote:
>> 
>> I upgraded my NUC8i7HVK test box to v6.1-rc1 and noticed that my suspend
>> tests with ath11k were broken, the box never woke up from suspend
>> automatically and I had to manually push the power button to trigger
>> resume. This is the command I used:
>> 
>> sudo rtcwake -m mem -s 30
>> 
>> v6.0 works without problems and a bisect found this commit:
>> 
>> commit 4919d3eb2ec0ee364f7e3cf2d99646c1b224fae8
>> Author:     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> AuthorDate: Wed Oct 12 20:07:01 2022 +0200
>> Commit:     Alexandre Belloni <alexandre.belloni@bootlin.com>
>> CommitDate: Thu Oct 13 23:27:52 2022 +0200
>> 
>>     rtc: cmos: Fix event handler registration ordering issue
>
> FWIW, Todd also reported this yesterday:
> https://lore.kernel.org/all/967cfe4e2dba242352ccd1cd00bdbcfb48bdd697.camel@linux.intel.com/
> https://bugzilla.kernel.org/show_bug.cgi?id=216600
>
> And Zhang Rui provided a patch in bugzilla that should fix this.

Thanks, this is good info. Strangely enough Zhang's workaround in [1]
did not fix the issue for me, rtcwake is still broken. Unfortunately no
time right now to investigate further.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=216600#c3

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [REGRESSION v6.1-rc1] rtc: cmos: rtcwake broken on NUC8i7HVK

[Rafael J. Wysocki]

On 10/18/2022 9:09 AM, Kalle Valo wrote:
> Thorsten Leemhuis <regressions@leemhuis.info> writes:
>
>> On 17.10.22 18:58, Kalle Valo wrote:
>>> I upgraded my NUC8i7HVK test box to v6.1-rc1 and noticed that my suspend
>>> tests with ath11k were broken, the box never woke up from suspend
>>> automatically and I had to manually push the power button to trigger
>>> resume. This is the command I used:
>>>
>>> sudo rtcwake -m mem -s 30
>>>
>>> v6.0 works without problems and a bisect found this commit:
>>>
>>> commit 4919d3eb2ec0ee364f7e3cf2d99646c1b224fae8
>>> Author:     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>> AuthorDate: Wed Oct 12 20:07:01 2022 +0200
>>> Commit:     Alexandre Belloni <alexandre.belloni@bootlin.com>
>>> CommitDate: Thu Oct 13 23:27:52 2022 +0200
>>>
>>>      rtc: cmos: Fix event handler registration ordering issue
>> FWIW, Todd also reported this yesterday:
>> https://lore.kernel.org/all/967cfe4e2dba242352ccd1cd00bdbcfb48bdd697.camel@linux.intel.com/
>> https://bugzilla.kernel.org/show_bug.cgi?id=216600
>>
>> And Zhang Rui provided a patch in bugzilla that should fix this.
> Thanks, this is good info. Strangely enough Zhang's workaround in [1]
> did not fix the issue for me, rtcwake is still broken. Unfortunately no
> time right now to investigate further.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=216600#c3
>
Please try https://lore.kernel.org/linux-acpi/5887691.lOV4Wx5bFT@kreacher/

Re: [REGRESSION v6.1-rc1] rtc: cmos: rtcwake broken on NUC8i7HVK

[Kalle Valo]

"Rafael J. Wysocki" <rafael.j.wysocki@intel.com> writes:

> On 10/18/2022 9:09 AM, Kalle Valo wrote:
>
>> Thorsten Leemhuis <regressions@leemhuis.info> writes:
>>
>>> On 17.10.22 18:58, Kalle Valo wrote:
>>>> I upgraded my NUC8i7HVK test box to v6.1-rc1 and noticed that my suspend
>>>> tests with ath11k were broken, the box never woke up from suspend
>>>> automatically and I had to manually push the power button to trigger
>>>> resume. This is the command I used:
>>>>
>>>> sudo rtcwake -m mem -s 30
>>>>
>>>> v6.0 works without problems and a bisect found this commit:
>>>>
>>>> commit 4919d3eb2ec0ee364f7e3cf2d99646c1b224fae8
>>>> Author:     Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>> AuthorDate: Wed Oct 12 20:07:01 2022 +0200
>>>> Commit:     Alexandre Belloni <alexandre.belloni@bootlin.com>
>>>> CommitDate: Thu Oct 13 23:27:52 2022 +0200
>>>>
>>>>      rtc: cmos: Fix event handler registration ordering issue
>>> FWIW, Todd also reported this yesterday:
>>> https://lore.kernel.org/all/967cfe4e2dba242352ccd1cd00bdbcfb48bdd697.camel@linux.intel.com/
>>> https://bugzilla.kernel.org/show_bug.cgi?id=216600
>>>
>>> And Zhang Rui provided a patch in bugzilla that should fix this.
>> Thanks, this is good info. Strangely enough Zhang's workaround in [1]
>> did not fix the issue for me, rtcwake is still broken. Unfortunately no
>> time right now to investigate further.
>>
>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=216600#c3
>
> Please try https://lore.kernel.org/linux-acpi/5887691.lOV4Wx5bFT@kreacher/

This works, thanks!

Tested-by: Kalle Valo <kvalo@kernel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches