* [PATCH v2] ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled
@ 2022-08-19 12:47 Cezary Rojewski
2022-08-19 12:40 ` Mark Brown
2022-08-19 12:56 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Cezary Rojewski @ 2022-08-19 12:47 UTC (permalink / raw)
To: alsa-devel, broonie, tiwai
Cc: Cezary Rojewski, kernel test robot, kai.vehmanen,
pierre-louis.bossart, hdegoede, amadeuszx.slawinski
hda_codec_device_init() expects three parameters, not two.
Fixes: 3fd63658caed ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
Changes in v2:
- adjusted SHA-1 provided in Fixes tag
sound/soc/sof/intel/hda-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c
index 73336648cd25..1e9afc48394c 100644
--- a/sound/soc/sof/intel/hda-codec.c
+++ b/sound/soc/sof/intel/hda-codec.c
@@ -213,7 +213,7 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address,
put_device(&codec->core.dev);
}
#else
- codec = hda_codec_device_init(&hbus->core, address);
+ codec = hda_codec_device_init(&hbus->core, address, HDA_DEV_ASOC);
ret = PTR_ERR_OR_ZERO(codec);
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled
2022-08-19 12:47 [PATCH v2] ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled Cezary Rojewski
@ 2022-08-19 12:40 ` Mark Brown
2022-08-19 12:56 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2022-08-19 12:40 UTC (permalink / raw)
To: Cezary Rojewski
Cc: alsa-devel, kernel test robot, kai.vehmanen, pierre-louis.bossart,
tiwai, hdegoede, amadeuszx.slawinski
[-- Attachment #1: Type: text/plain, Size: 169 bytes --]
On Fri, Aug 19, 2022 at 02:47:40PM +0200, Cezary Rojewski wrote:
> hda_codec_device_init() expects three parameters, not two.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled
2022-08-19 12:47 [PATCH v2] ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled Cezary Rojewski
2022-08-19 12:40 ` Mark Brown
@ 2022-08-19 12:56 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2022-08-19 12:56 UTC (permalink / raw)
To: Cezary Rojewski
Cc: alsa-devel, kernel test robot, kai.vehmanen, pierre-louis.bossart,
tiwai, hdegoede, broonie, amadeuszx.slawinski
On Fri, 19 Aug 2022 14:47:40 +0200,
Cezary Rojewski wrote:
>
> hda_codec_device_init() expects three parameters, not two.
>
> Fixes: 3fd63658caed ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
>
> Changes in v2:
> - adjusted SHA-1 provided in Fixes tag
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-19 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-19 12:47 [PATCH v2] ASoC: SOF: Fix compilation when HDA_AUDIO_CODEC config is disabled Cezary Rojewski
2022-08-19 12:40 ` Mark Brown
2022-08-19 12:56 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.