From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while initializing
Date: Thu, 23 Jun 2022 10:37:54 +0200 [thread overview]
Message-ID: <87edzf93ml.fsf@redhat.com> (raw)
In-Reply-To: <20220623071131.412457-2-thuth@redhat.com>
On Thu, Jun 23 2022, Thomas Huth <thuth@redhat.com> wrote:
> According chapter "3.1.1 Driver Requirements: Device Initialization"
> of the Virtio specification (v1.1), a driver for a device has to set
> the ACKNOWLEDGE and DRIVER bits in the status field after resetting
> the device. The s390-ccw bios skipped these steps so far and seems
> like QEMU never cared. Anyway, it's better to follow the spec, so
> let's set these bits now in the right spots, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/virtio.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
The QEMU implementation seems to be pretty tolerant :)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2022-06-23 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 7:11 [PATCH 0/2] pc-bios/s390-ccw: Two fixes for the virtio initialization Thomas Huth
2022-06-23 7:11 ` [PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while initializing Thomas Huth
2022-06-23 7:59 ` Christian Borntraeger
2022-06-23 8:37 ` Cornelia Huck [this message]
2022-06-23 13:50 ` Eric Farman
2022-06-23 7:11 ` [PATCH 2/2] pc-bios/s390-ccw/virtio: Read device config after feature negotiation Thomas Huth
2022-06-23 8:44 ` Cornelia Huck
2022-06-23 9:55 ` Thomas Huth
2022-06-23 10:13 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edzf93ml.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.