All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <quic_wgong@quicinc.com>
Cc: P Praneesh <ppranees@codeaurora.org>,
	<ath11k@lists.infradead.org>, <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>,
	"Karthikeyan Periyasamy" <periyasa@codeaurora.org>
Subject: Re: [PATCH v3 2/3] ath11k: Refactor update channel list function
Date: Wed, 24 Nov 2021 09:56:08 +0200	[thread overview]
Message-ID: <87ee766l7r.fsf@codeaurora.org> (raw)
In-Reply-To: <5929130a-7824-acd1-0182-da8fa304c576@quicinc.com> (Wen Gong's message of "Wed, 24 Nov 2021 15:48:03 +0800")

Wen Gong <quic_wgong@quicinc.com> writes:

> On 11/24/2021 3:39 PM, Kalle Valo wrote:
>> Wen Gong <quic_wgong@quicinc.com> writes:
>>
>>> On 10/22/2021 8:37 PM, P Praneesh wrote:
>>>
>>> ...
>>>
>>>> ---
>>>> ...
>>>> -			ch->maxpower = channel->max_power * 2;
>>>> -			ch->maxregpower = channel->max_reg_power * 2;
>>>> -			ch->antennamax = channel->max_antenna_gain * 2;
>>>> ...
>>>>    +int ath11k_wmi_update_scan_chan_list(struct ath11k *ar,
>>>> +				     struct scan_req_params *arg)
>>>> ...
>>>> +			ch->maxpower = channel->max_power;
>>>> +			ch->maxregpower = channel->max_reg_power;
>>>> +			ch->antennamax = channel->max_antenna_gain;
>>>> +
>>>> ...
>>> I see it also have another patch to remove the "*2" for power.
>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=9212c1b9e80a869e732769a4fe7f82d392b219be
>>>
>>> ath11k: send proper txpower and maxregpower values to firmware.
>>>
>>> so are you the same reason to remove "*2" ?
>> I'm not quite getting what you are saying, can you elaborate more? Did
>> this patch break something?
>
> Oh. Not see break anything.
>
> I just want to know why remove the "*2". Did you see any issue if NOT
> remove "*2"?

All I know is that commit 9212c1b9e80a ("ath11k: send proper txpower and
maxregpower values to firmware") mentions about cca getting stuck:

ath11k: send proper txpower and maxregpower values to firmware

Set proper values for max_regpower, max_power, max_antenna_gain as it
is because firmware will convert power values to 0.5dbm steps by
multiplying it with 2.

If txpower is not set, it will lead to cca stuck resulting in latency
issues for QCN9074.

Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01386-QCAHKSWPL_SILICONZ-1

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <quic_wgong@quicinc.com>
Cc: P Praneesh <ppranees@codeaurora.org>,
	<ath11k@lists.infradead.org>, <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>,
	"Karthikeyan Periyasamy" <periyasa@codeaurora.org>
Subject: Re: [PATCH v3 2/3] ath11k: Refactor update channel list function
Date: Wed, 24 Nov 2021 09:56:08 +0200	[thread overview]
Message-ID: <87ee766l7r.fsf@codeaurora.org> (raw)
In-Reply-To: <5929130a-7824-acd1-0182-da8fa304c576@quicinc.com> (Wen Gong's message of "Wed, 24 Nov 2021 15:48:03 +0800")

Wen Gong <quic_wgong@quicinc.com> writes:

> On 11/24/2021 3:39 PM, Kalle Valo wrote:
>> Wen Gong <quic_wgong@quicinc.com> writes:
>>
>>> On 10/22/2021 8:37 PM, P Praneesh wrote:
>>>
>>> ...
>>>
>>>> ---
>>>> ...
>>>> -			ch->maxpower = channel->max_power * 2;
>>>> -			ch->maxregpower = channel->max_reg_power * 2;
>>>> -			ch->antennamax = channel->max_antenna_gain * 2;
>>>> ...
>>>>    +int ath11k_wmi_update_scan_chan_list(struct ath11k *ar,
>>>> +				     struct scan_req_params *arg)
>>>> ...
>>>> +			ch->maxpower = channel->max_power;
>>>> +			ch->maxregpower = channel->max_reg_power;
>>>> +			ch->antennamax = channel->max_antenna_gain;
>>>> +
>>>> ...
>>> I see it also have another patch to remove the "*2" for power.
>>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=9212c1b9e80a869e732769a4fe7f82d392b219be
>>>
>>> ath11k: send proper txpower and maxregpower values to firmware.
>>>
>>> so are you the same reason to remove "*2" ?
>> I'm not quite getting what you are saying, can you elaborate more? Did
>> this patch break something?
>
> Oh. Not see break anything.
>
> I just want to know why remove the "*2". Did you see any issue if NOT
> remove "*2"?

All I know is that commit 9212c1b9e80a ("ath11k: send proper txpower and
maxregpower values to firmware") mentions about cca getting stuck:

ath11k: send proper txpower and maxregpower values to firmware

Set proper values for max_regpower, max_power, max_antenna_gain as it
is because firmware will convert power values to 0.5dbm steps by
multiplying it with 2.

If txpower is not set, it will lead to cca stuck resulting in latency
issues for QCN9074.

Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01386-QCAHKSWPL_SILICONZ-1

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2021-11-24  7:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 12:37 [PATCH v3 0/3] mac80211: Add extended ROC support for 40-80 MHz bandwidth P Praneesh
2021-10-22 12:37 ` P Praneesh
2021-10-22 12:37 ` [PATCH v3 1/3] nl80211: Extended " P Praneesh
2021-10-22 12:37   ` P Praneesh
2021-10-25 19:59   ` Johannes Berg
2021-10-25 19:59     ` Johannes Berg
2021-10-22 12:37 ` [PATCH v3 2/3] ath11k: Refactor update channel list function P Praneesh
2021-10-22 12:37   ` P Praneesh
2021-11-12  8:31   ` Kalle Valo
2021-11-12  8:31     ` Kalle Valo
2021-11-24  3:50   ` Wen Gong
2021-11-24  3:50     ` Wen Gong
2021-11-24  7:39     ` Kalle Valo
2021-11-24  7:39       ` Kalle Valo
2021-11-24  7:48       ` Wen Gong
2021-11-24  7:48         ` Wen Gong
2021-11-24  7:56         ` Kalle Valo [this message]
2021-11-24  7:56           ` Kalle Valo
2021-10-22 12:37 ` [PATCH v3 2/3] ath11k: Add ROC support for wide band scan P Praneesh
2021-10-22 12:37   ` P Praneesh
2021-10-25 20:10   ` Johannes Berg
2021-10-25 20:10     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee766l7r.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=periyasa@codeaurora.org \
    --cc=ppranees@codeaurora.org \
    --cc=quic_wgong@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.