From: Jonathan Corbet <corbet@lwn.net>
To: Fengnan Chang <changfengnan@vivo.com>,
jaegeuk@kernel.org, chao@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-doc@vger.kernel.org, Fengnan Chang <changfengnan@vivo.com>
Subject: Re: [PATCH] f2fs: fix f2fs.rst build warning
Date: Tue, 26 Oct 2021 09:37:33 -0600 [thread overview]
Message-ID: <87ee87g5ky.fsf@meer.lwn.net> (raw)
In-Reply-To: <20211023025833.216030-1-changfengnan@vivo.com>
Fengnan Chang <changfengnan@vivo.com> writes:
> fix f2fs.rst build warning.
>
> Fixes: 151b1982be5d (f2fs: compress: add nocompress extensions support)
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> ---
> Documentation/filesystems/f2fs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
"Fix a warning" is almost never a good changelog message; you are fixing
a problem that provoked a warning. I rewrote the changelog to:
The docs build was generating this warning:
Documentation/filesystems/f2fs.rst:306: WARNING: Block quote ends without a blank line; unexpected unindent.
Remove the extra white space that was confusing sphinx.
Applied, thanks.
jon
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Fengnan Chang <changfengnan@vivo.com>,
jaegeuk@kernel.org, chao@kernel.org
Cc: linux-doc@vger.kernel.org, Fengnan Chang <changfengnan@vivo.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix f2fs.rst build warning
Date: Tue, 26 Oct 2021 09:37:33 -0600 [thread overview]
Message-ID: <87ee87g5ky.fsf@meer.lwn.net> (raw)
In-Reply-To: <20211023025833.216030-1-changfengnan@vivo.com>
Fengnan Chang <changfengnan@vivo.com> writes:
> fix f2fs.rst build warning.
>
> Fixes: 151b1982be5d (f2fs: compress: add nocompress extensions support)
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
> ---
> Documentation/filesystems/f2fs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
"Fix a warning" is almost never a good changelog message; you are fixing
a problem that provoked a warning. I rewrote the changelog to:
The docs build was generating this warning:
Documentation/filesystems/f2fs.rst:306: WARNING: Block quote ends without a blank line; unexpected unindent.
Remove the extra white space that was confusing sphinx.
Applied, thanks.
jon
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-10-26 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-23 2:58 [PATCH] f2fs: fix f2fs.rst build warning Fengnan Chang
2021-10-23 2:58 ` [f2fs-dev] " Fengnan Chang
2021-10-26 0:19 ` Chao Yu
2021-10-26 0:19 ` [f2fs-dev] " Chao Yu
2021-10-26 15:37 ` Jonathan Corbet [this message]
2021-10-26 15:37 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee87g5ky.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=changfengnan@vivo.com \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.