From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: John Crispin <john@phrozen.org>,
Johannes Berg <johannes@sipsolutions.net>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 1/2] mac80211: allow setting queue_len for drivers not using wake_tx_queue
Date: Tue, 11 Feb 2020 13:29:44 +0100 [thread overview]
Message-ID: <87eev1b93b.fsf@toke.dk> (raw)
In-Reply-To: <20200211122605.13002-1-john@phrozen.org>
John Crispin <john@phrozen.org> writes:
> Currently a mac80211 driver can only set the txq_limit when using
> wake_tx_queue. Not all drivers use wake_tx_queue. This patch adds a new
> element to wiphy allowing a driver to set a custom tx_queue_len and the
> code that will apply it in case it is set. The current default is
> 1000 which is too low for ath11k when doing HE rates.
Fine, but we should really fix ath11k to do something smarter than a
fixed queue len... 4096 packets is 6 seconds of queueing at 8Mbps :/
-Toke
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: John Crispin <john@phrozen.org>,
Johannes Berg <johannes@sipsolutions.net>,
Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH 1/2] mac80211: allow setting queue_len for drivers not using wake_tx_queue
Date: Tue, 11 Feb 2020 13:29:44 +0100 [thread overview]
Message-ID: <87eev1b93b.fsf@toke.dk> (raw)
In-Reply-To: <20200211122605.13002-1-john@phrozen.org>
John Crispin <john@phrozen.org> writes:
> Currently a mac80211 driver can only set the txq_limit when using
> wake_tx_queue. Not all drivers use wake_tx_queue. This patch adds a new
> element to wiphy allowing a driver to set a custom tx_queue_len and the
> code that will apply it in case it is set. The current default is
> 1000 which is too low for ath11k when doing HE rates.
Fine, but we should really fix ath11k to do something smarter than a
fixed queue len... 4096 packets is 6 seconds of queueing at 8Mbps :/
-Toke
next prev parent reply other threads:[~2020-02-11 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 12:26 [PATCH 1/2] mac80211: allow setting queue_len for drivers not using wake_tx_queue John Crispin
2020-02-11 12:26 ` John Crispin
2020-02-11 12:26 ` [PATCH 2/2] ath11k: set queue_len to 4096 John Crispin
2020-02-11 12:26 ` John Crispin
2020-03-17 6:40 ` Kalle Valo
2020-03-17 6:40 ` Kalle Valo
2020-02-11 12:29 ` Toke Høiland-Jørgensen [this message]
2020-02-11 12:29 ` [PATCH 1/2] mac80211: allow setting queue_len for drivers not using wake_tx_queue Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eev1b93b.fsf@toke.dk \
--to=toke@redhat.com \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=john@phrozen.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.