From: Kalle Valo <kvalo@codeaurora.org>
To: vthiagar@codeaurora.org
Cc: linux-wireless-owner@vger.kernel.org,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
John Crispin <john@phrozen.org>
Subject: Re: [RESEND 6/9] ath11k: add debugfs for TWT debug calls
Date: Thu, 19 Dec 2019 15:25:55 +0200 [thread overview]
Message-ID: <87eex078gs.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <0101016ecf7e75e3-b26c2edc-e278-4fbc-97d5-fc7f678c240f-000000@us-west-2.amazonses.com> (vthiagar@codeaurora.org's message of "Wed, 4 Dec 2019 06:00:03 +0000")
vthiagar@codeaurora.org writes:
> On 2019-12-04 11:07, John Crispin wrote:
>> These new debugfs files allow us to manually add/del/pause/resume TWT
>> dialogs for test/debug purposes.
>>
>
> Information such as how these debugfs entries are supposed to be used
> could be helpful.
Yes, please always add instructions how the debugfs file is supposed to
be used. Not only it helps the users but makes the review easier as
well.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: vthiagar@codeaurora.org
Cc: John Crispin <john@phrozen.org>,
linux-wireless-owner@vger.kernel.org,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [RESEND 6/9] ath11k: add debugfs for TWT debug calls
Date: Thu, 19 Dec 2019 15:25:55 +0200 [thread overview]
Message-ID: <87eex078gs.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <0101016ecf7e75e3-b26c2edc-e278-4fbc-97d5-fc7f678c240f-000000@us-west-2.amazonses.com> (vthiagar@codeaurora.org's message of "Wed, 4 Dec 2019 06:00:03 +0000")
vthiagar@codeaurora.org writes:
> On 2019-12-04 11:07, John Crispin wrote:
>> These new debugfs files allow us to manually add/del/pause/resume TWT
>> dialogs for test/debug purposes.
>>
>
> Information such as how these debugfs entries are supposed to be used
> could be helpful.
Yes, please always add instructions how the debugfs file is supposed to
be used. Not only it helps the users but makes the review easier as
well.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-12-19 13:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 5:37 [RESEND 0/9] ath11k: resend pending patches John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 5:37 ` [RESEND 1/9] ath11k: add wmi helper for turning STA PS on/off John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-10 17:35 ` Kalle Valo
2019-12-10 17:35 ` Kalle Valo
2019-12-04 5:37 ` [RESEND 2/9] ath11k: disable PS for STA interfaces by default upon bringup John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 5:37 ` [RESEND 3/9] ath11k: drop memset when setting up a tx cmd desc John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 5:37 ` [RESEND 4/9] ath11k: rename ath11k_wmi_base instances from wmi_sc to wmi_ab John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 5:37 ` [RESEND 5/9] ath11k: add WMI calls to manually add/del/pause/resume TWT dialogs John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 5:55 ` vthiagar
2019-12-04 5:55 ` vthiagar
2019-12-04 5:37 ` [RESEND 6/9] ath11k: add debugfs for TWT debug calls John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 6:00 ` vthiagar
2019-12-04 6:00 ` vthiagar
2019-12-19 13:25 ` Kalle Valo [this message]
2019-12-19 13:25 ` Kalle Valo
2019-12-19 13:45 ` John Crispin
2019-12-19 13:45 ` John Crispin
2019-12-04 5:37 ` [RESEND 7/9] ath11k: move some tx_status parsing to debugfs code John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 5:37 ` [RESEND 8/9] ath11k: optimise ath11k_dp_tx_completion_handler John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 5:37 ` [RESEND 9/9] ath11k: optimize ath11k_hal_tx_status_parse John Crispin
2019-12-04 5:37 ` John Crispin
2019-12-04 6:02 ` vthiagar
2019-12-04 6:02 ` vthiagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eex078gs.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.