All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Stephen Brennan <stephen@brennan.io>,
	linux-arm-kernel@lists.infradead.org
Cc: stephen@brennan.io, Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Scott Branden <sbranden@broadcom.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ray Jui <rjui@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Matthias Brugger <mbrugger@suse.com>,
	Eric Anholt <eric@anholt.net>, Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Stefan Wahren <wahrenst@gmx.net>, Matt Mackall <mpm@selenic.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3 2/4] hwrng: iproc-rng200: Add support for BCM2711
Date: Wed, 20 Nov 2019 06:52:47 +0200	[thread overview]
Message-ID: <87eey3gnds.fsf@tarshish> (raw)
In-Reply-To: <20191120031622.88949-3-stephen@brennan.io>

Hi Stephen, Stefan,

On Wed, Nov 20 2019, Stephen Brennan wrote:
> From: Stefan Wahren <wahrenst@gmx.net>
>
> BCM2711 features a RNG200 hardware random number generator block.
> So make the driver available.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Stephen Brennan <stephen@brennan.io>
> Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
>  drivers/char/hw_random/Kconfig        | 2 +-
>  drivers/char/hw_random/iproc-rng200.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 7c7fecfa2fb2..77e848fca531 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -90,7 +90,7 @@ config HW_RANDOM_BCM2835
>  
>  config HW_RANDOM_IPROC_RNG200
>  	tristate "Broadcom iProc/STB RNG200 support"
> -	depends on ARCH_BCM_IPROC || ARCH_BRCMSTB
> +	depends on ARCH_BCM_IPROC || ARCH_BCM2835 || ARCH_BRCMSTB
>  	default HW_RANDOM
>  	---help---
>  	  This driver provides kernel-side support for the RNG200
> diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
> index 899ff25f4f28..32d9fe61a225 100644
> --- a/drivers/char/hw_random/iproc-rng200.c
> +++ b/drivers/char/hw_random/iproc-rng200.c
> @@ -213,6 +213,7 @@ static int iproc_rng200_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id iproc_rng200_of_match[] = {
> +	{ .compatible = "brcm,bcm2711-rng200", },
>  	{ .compatible = "brcm,bcm7211-rng200", },

Again, duplicate of commit 1fa6d053b2a5.

>  	{ .compatible = "brcm,bcm7278-rng200", },
>  	{ .compatible = "brcm,iproc-rng200", },

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch@tkos.co.il>
To: Stephen Brennan <stephen@brennan.io>,
	linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Scott Branden <sbranden@broadcom.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matt Mackall <mpm@selenic.com>, Stefan Wahren <wahrenst@gmx.net>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-crypto@vger.kernel.org, Eric Anholt <eric@anholt.net>,
	Matthias Brugger <mbrugger@suse.com>,
	bcm-kernel-feedback-list@broadcom.com, stephen@brennan.io,
	Ray Jui <rjui@broadcom.com>, Arnd Bergmann <arnd@arndb.de>,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] hwrng: iproc-rng200: Add support for BCM2711
Date: Wed, 20 Nov 2019 06:52:47 +0200	[thread overview]
Message-ID: <87eey3gnds.fsf@tarshish> (raw)
In-Reply-To: <20191120031622.88949-3-stephen@brennan.io>

Hi Stephen, Stefan,

On Wed, Nov 20 2019, Stephen Brennan wrote:
> From: Stefan Wahren <wahrenst@gmx.net>
>
> BCM2711 features a RNG200 hardware random number generator block.
> So make the driver available.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Stephen Brennan <stephen@brennan.io>
> Reviewed-by: Matthias Brugger <mbrugger@suse.com>
> ---
>  drivers/char/hw_random/Kconfig        | 2 +-
>  drivers/char/hw_random/iproc-rng200.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 7c7fecfa2fb2..77e848fca531 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -90,7 +90,7 @@ config HW_RANDOM_BCM2835
>  
>  config HW_RANDOM_IPROC_RNG200
>  	tristate "Broadcom iProc/STB RNG200 support"
> -	depends on ARCH_BCM_IPROC || ARCH_BRCMSTB
> +	depends on ARCH_BCM_IPROC || ARCH_BCM2835 || ARCH_BRCMSTB
>  	default HW_RANDOM
>  	---help---
>  	  This driver provides kernel-side support for the RNG200
> diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
> index 899ff25f4f28..32d9fe61a225 100644
> --- a/drivers/char/hw_random/iproc-rng200.c
> +++ b/drivers/char/hw_random/iproc-rng200.c
> @@ -213,6 +213,7 @@ static int iproc_rng200_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id iproc_rng200_of_match[] = {
> +	{ .compatible = "brcm,bcm2711-rng200", },
>  	{ .compatible = "brcm,bcm7211-rng200", },

Again, duplicate of commit 1fa6d053b2a5.

>  	{ .compatible = "brcm,bcm7278-rng200", },
>  	{ .compatible = "brcm,iproc-rng200", },

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-20  5:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20  3:16 [PATCH v3 0/4] Raspberry Pi 4 HWRNG Support Stephen Brennan
2019-11-20  3:16 ` Stephen Brennan
2019-11-20  3:16 ` [PATCH v3 1/4] dt-bindings: rng: add BCM2711 RNG compatible Stephen Brennan
2019-11-20  3:16   ` Stephen Brennan
2019-11-20  4:50   ` Baruch Siach
2019-11-20  4:50     ` Baruch Siach
2019-11-20  5:21     ` Stephen Brennan
2019-11-20  5:21       ` Stephen Brennan
2019-11-20 19:55   ` Florian Fainelli
2019-11-20 19:55     ` Florian Fainelli
2019-11-23  0:39   ` Rob Herring
2019-11-23  0:39     ` Rob Herring
2019-11-20  3:16 ` [PATCH v3 2/4] hwrng: iproc-rng200: Add support for BCM2711 Stephen Brennan
2019-11-20  3:16   ` Stephen Brennan
2019-11-20  4:52   ` Baruch Siach [this message]
2019-11-20  4:52     ` Baruch Siach
2019-11-20 17:33     ` Matthias Brugger
2019-11-20 17:33       ` Matthias Brugger
2019-11-20 19:55   ` Florian Fainelli
2019-11-20 19:55     ` Florian Fainelli
2019-11-20  3:16 ` [PATCH v3 3/4] ARM: dts: bcm2835: Move rng definition to common location Stephen Brennan
2019-11-20  3:16   ` Stephen Brennan
2019-11-20 16:20   ` Stefan Wahren
2019-11-20 16:20     ` Stefan Wahren
2019-11-20  3:16 ` [PATCH v3 4/4] ARM: dts: bcm2711: Enable HWRNG support Stephen Brennan
2019-11-20  3:16   ` Stephen Brennan
2019-11-20 16:21   ` Stefan Wahren
2019-11-20 16:21     ` Stefan Wahren
2019-11-20 19:45   ` Nicolas Saenz Julienne
2019-11-20 19:45     ` Nicolas Saenz Julienne
2019-11-20 16:16 ` [PATCH v3 0/4] Raspberry Pi 4 HWRNG Support Stefan Wahren
2019-11-20 16:16   ` Stefan Wahren
2019-11-20 19:50   ` Nicolas Saenz Julienne
2019-11-20 19:50     ` Nicolas Saenz Julienne
2019-11-21 10:14     ` Stefan Wahren
2019-11-21 10:14       ` Stefan Wahren
2019-11-21  4:09 ` Florian Fainelli
2019-11-21  4:09   ` Florian Fainelli
2019-11-21  5:30   ` Herbert Xu
2019-11-21  5:30     ` Herbert Xu
2019-12-04  4:55     ` Florian Fainelli
2019-12-04  4:55       ` Florian Fainelli
2019-12-04  4:59       ` Herbert Xu
2019-12-04  4:59         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eey3gnds.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mbrugger@suse.com \
    --cc=mpm@selenic.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stephen@brennan.io \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.