From: Kalle Valo <kvalo@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Wenwen Wang <wenwen@cs.uga.edu>,
govinds@codeaurora.org, jeffrey.l.hugo@gmail.com,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"open list:NETWORKING DRIVERS (WIRELESS)"
<linux-wireless@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER"
<ath10k@lists.infradead.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()
Date: Thu, 14 Nov 2019 09:42:52 +0200 [thread overview]
Message-ID: <87eeyax5s3.fsf@codeaurora.org> (raw)
In-Reply-To: <20191113192821.GA3441686@builder> (Bjorn Andersson's message of "Wed, 13 Nov 2019 11:28:21 -0800")
Bjorn Andersson <bjorn.andersson@linaro.org> writes:
> On Thu 15 Aug 14:04 PDT 2019, Wenwen Wang wrote:
>
>> If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource
>> leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before
>> go to the 'exit' label.
>>
>
> Unfortunately this patch consistently crashes all my msm8998, sdm845 and
> qcs404 devices (running ath10k_snoc). Upon trying to join a network the
> WiFi firmware crashes with the following:
>
> [ 124.315286] wlan0: authenticate with 70:3a:cb:4d:34:f3
> [ 124.334051] wlan0: send auth to 70:3a:cb:4d:34:f3 (try 1/3)
> [ 124.338828] wlan0: authenticated
> [ 124.342470] wlan0: associate with 70:3a:cb:4d:34:f3 (try 1/3)
> [ 124.347223] wlan0: RX AssocResp from 70:3a:cb:4d:34:f3 (capab=0x1011 status=0 aid=2)
> [ 124.402535] qcom-q6v5-mss 4080000.remoteproc: fatal error received:
> err_qdi.c:456:EF:wlan_process:1:cmnos_thread.c:3900:Asserted in
> wlan_vdev.c:_wlan_vdev_up:3219
>
> Can we please revert it for v5.5?
Yes, let's revert it. And thanks for sending the patch to do that:
https://patchwork.kernel.org/patch/11242743/
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Wenwen Wang <wenwen@cs.uga.edu>,
"David S. Miller" <davem@davemloft.net>,
"open list\:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER"
<ath10k@lists.infradead.org>,
"open list\:NETWORKING DRIVERS \(WIRELESS\)"
<linux-wireless@vger.kernel.org>,
"open list\:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
jeffrey.l.hugo@gmail.com, govinds@codeaurora.org
Subject: Re: [PATCH] ath10k: add cleanup in ath10k_sta_state()
Date: Thu, 14 Nov 2019 09:42:52 +0200 [thread overview]
Message-ID: <87eeyax5s3.fsf@codeaurora.org> (raw)
In-Reply-To: <20191113192821.GA3441686@builder> (Bjorn Andersson's message of "Wed, 13 Nov 2019 11:28:21 -0800")
Bjorn Andersson <bjorn.andersson@linaro.org> writes:
> On Thu 15 Aug 14:04 PDT 2019, Wenwen Wang wrote:
>
>> If 'sta->tdls' is false, no cleanup is executed, leading to memory/resource
>> leaks, e.g., 'arsta->tx_stats'. To fix this issue, perform cleanup before
>> go to the 'exit' label.
>>
>
> Unfortunately this patch consistently crashes all my msm8998, sdm845 and
> qcs404 devices (running ath10k_snoc). Upon trying to join a network the
> WiFi firmware crashes with the following:
>
> [ 124.315286] wlan0: authenticate with 70:3a:cb:4d:34:f3
> [ 124.334051] wlan0: send auth to 70:3a:cb:4d:34:f3 (try 1/3)
> [ 124.338828] wlan0: authenticated
> [ 124.342470] wlan0: associate with 70:3a:cb:4d:34:f3 (try 1/3)
> [ 124.347223] wlan0: RX AssocResp from 70:3a:cb:4d:34:f3 (capab=0x1011 status=0 aid=2)
> [ 124.402535] qcom-q6v5-mss 4080000.remoteproc: fatal error received:
> err_qdi.c:456:EF:wlan_process:1:cmnos_thread.c:3900:Asserted in
> wlan_vdev.c:_wlan_vdev_up:3219
>
> Can we please revert it for v5.5?
Yes, let's revert it. And thanks for sending the patch to do that:
https://patchwork.kernel.org/patch/11242743/
--
Kalle Valo
next prev parent reply other threads:[~2019-11-14 7:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 21:04 [PATCH] ath10k: add cleanup in ath10k_sta_state() Wenwen Wang
2019-08-15 21:04 ` Wenwen Wang
2019-08-16 10:31 ` Sebastian Gottschall
2019-09-17 14:11 ` Kalle Valo
2019-09-17 14:11 ` Kalle Valo
2019-11-13 19:28 ` Bjorn Andersson
2019-11-13 19:28 ` Bjorn Andersson
2019-11-13 19:37 ` Jeffrey Hugo
2019-11-13 19:37 ` Jeffrey Hugo
2019-11-14 7:42 ` Kalle Valo [this message]
2019-11-14 7:42 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeyax5s3.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=govinds@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wenwen@cs.uga.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.