All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: liupold <rohn.ch@gmail.com>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Fixed "Failed to wake target" QCA6174
Date: Wed, 30 Oct 2019 16:25:50 +0200	[thread overview]
Message-ID: <87eeyu2tu9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20191030125035.31848-1-rohn.ch@gmail.com> (liupold's message of "Wed, 30 Oct 2019 18:20:35 +0530")

+ ath10k list

liupold <rohn.ch@gmail.com> writes:

> There is a issue with card about waking up during boot and from suspend
> the only way to prevent it (is seems) by making pci_ps = false,
> on Acer Swift 3 (ryzen 2500u).

Can you provide dmesg output when this problem happens? Was QCA6174
installed to Swift 3 by default at the factory or did you install it
afterwards on your own?

> Signed-off-by: liupold <rohn.ch@gmail.com>

Is 'liupold' your full legal name?

> ---
>  drivers/net/wireless/ath/ath10k/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
> index a0b4d265c6eb..653590342619 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -3514,7 +3514,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
>  	case QCA6164_2_1_DEVICE_ID:
>  	case QCA6174_2_1_DEVICE_ID:
>  		hw_rev = ATH10K_HW_QCA6174;
> -		pci_ps = true;
> +		pci_ps = false;
>  		pci_soft_reset = ath10k_pci_warm_reset;
>  		pci_hard_reset = ath10k_pci_qca6174_chip_reset;
>  		targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;

This increases power consumption for all QCA6174 devices so I'm not
eager to do this.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: liupold <rohn.ch@gmail.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Fixed "Failed to wake target" QCA6174
Date: Wed, 30 Oct 2019 16:25:50 +0200	[thread overview]
Message-ID: <87eeyu2tu9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20191030125035.31848-1-rohn.ch@gmail.com> (liupold's message of "Wed, 30 Oct 2019 18:20:35 +0530")

+ ath10k list

liupold <rohn.ch@gmail.com> writes:

> There is a issue with card about waking up during boot and from suspend
> the only way to prevent it (is seems) by making pci_ps = false,
> on Acer Swift 3 (ryzen 2500u).

Can you provide dmesg output when this problem happens? Was QCA6174
installed to Swift 3 by default at the factory or did you install it
afterwards on your own?

> Signed-off-by: liupold <rohn.ch@gmail.com>

Is 'liupold' your full legal name?

> ---
>  drivers/net/wireless/ath/ath10k/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
> index a0b4d265c6eb..653590342619 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -3514,7 +3514,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
>  	case QCA6164_2_1_DEVICE_ID:
>  	case QCA6174_2_1_DEVICE_ID:
>  		hw_rev = ATH10K_HW_QCA6174;
> -		pci_ps = true;
> +		pci_ps = false;
>  		pci_soft_reset = ath10k_pci_warm_reset;
>  		pci_hard_reset = ath10k_pci_qca6174_chip_reset;
>  		targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;

This increases power consumption for all QCA6174 devices so I'm not
eager to do this.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2019-10-30 14:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 12:50 [PATCH] ath10k: Fixed "Failed to wake target" QCA6174 liupold
2019-10-30 14:25 ` Kalle Valo [this message]
2019-10-30 14:25   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeyu2tu9.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rohn.ch@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.