From: Jani Nikula <jani.nikula@linux.intel.com>
To: airlied@redhat.com
Cc: Robert Tarasov <tutankhamen@chromium.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/udl: Bugfix in EDID reading routine
Date: Mon, 11 Mar 2019 13:35:17 +0200 [thread overview]
Message-ID: <87ef7dlk3u.fsf@intel.com> (raw)
In-Reply-To: <20190309033001.177520-1-tutankhamen@chromium.org>
On Fri, 08 Mar 2019, Robert Tarasov <tutankhamen@chromium.org> wrote:
> Fixed bug with reading of last EDID extra block in drm/udl driver.
> Previouse approach read all the blocks except the last one.
>
> Signed-off-by: Robert Tarasov <tutankhamen@chromium.org>
> ---
> drivers/gpu/drm/udl/udl_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c
> index c3dc1fd20cb4..68b221b9a01f 100644
> --- a/drivers/gpu/drm/udl/udl_connector.c
> +++ b/drivers/gpu/drm/udl/udl_connector.c
> @@ -70,7 +70,7 @@ static bool udl_get_edid(struct udl_device *udl, u8 **result_buff,
> memcpy(buff_ptr, block_buff, EDID_LENGTH);
> kfree(block_buff);
> buff_ptr += EDID_LENGTH;
> - for (i = 1; i < extensions; ++i) {
> + for (i = 1; i <= extensions; ++i) {
> if (udl_get_edid_block(udl, i, buff_ptr)) {
> buff_ptr += EDID_LENGTH;
> } else {
Ugh. Why doesn't udl use drm_do_get_edid()?
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-11 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 3:30 [PATCH] drm/udl: Bugfix in EDID reading routine Robert Tarasov
2019-03-11 11:35 ` Jani Nikula [this message]
2019-03-12 4:13 ` Robert Tarasov
2019-03-12 8:01 ` Jani Nikula
2019-03-13 1:05 ` Robert Tarasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef7dlk3u.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tutankhamen@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.