* [PATCH] drm/udl: Bugfix in EDID reading routine @ 2019-03-09 3:30 Robert Tarasov 2019-03-11 11:35 ` Jani Nikula 0 siblings, 1 reply; 5+ messages in thread From: Robert Tarasov @ 2019-03-09 3:30 UTC (permalink / raw) To: airlied; +Cc: Robert Tarasov, dri-devel Fixed bug with reading of last EDID extra block in drm/udl driver. Previouse approach read all the blocks except the last one. Signed-off-by: Robert Tarasov <tutankhamen@chromium.org> --- drivers/gpu/drm/udl/udl_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c index c3dc1fd20cb4..68b221b9a01f 100644 --- a/drivers/gpu/drm/udl/udl_connector.c +++ b/drivers/gpu/drm/udl/udl_connector.c @@ -70,7 +70,7 @@ static bool udl_get_edid(struct udl_device *udl, u8 **result_buff, memcpy(buff_ptr, block_buff, EDID_LENGTH); kfree(block_buff); buff_ptr += EDID_LENGTH; - for (i = 1; i < extensions; ++i) { + for (i = 1; i <= extensions; ++i) { if (udl_get_edid_block(udl, i, buff_ptr)) { buff_ptr += EDID_LENGTH; } else { -- 2.21.0.360.g471c308f928-goog _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/udl: Bugfix in EDID reading routine 2019-03-09 3:30 [PATCH] drm/udl: Bugfix in EDID reading routine Robert Tarasov @ 2019-03-11 11:35 ` Jani Nikula 2019-03-12 4:13 ` Robert Tarasov 0 siblings, 1 reply; 5+ messages in thread From: Jani Nikula @ 2019-03-11 11:35 UTC (permalink / raw) To: airlied; +Cc: Robert Tarasov, dri-devel On Fri, 08 Mar 2019, Robert Tarasov <tutankhamen@chromium.org> wrote: > Fixed bug with reading of last EDID extra block in drm/udl driver. > Previouse approach read all the blocks except the last one. > > Signed-off-by: Robert Tarasov <tutankhamen@chromium.org> > --- > drivers/gpu/drm/udl/udl_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c > index c3dc1fd20cb4..68b221b9a01f 100644 > --- a/drivers/gpu/drm/udl/udl_connector.c > +++ b/drivers/gpu/drm/udl/udl_connector.c > @@ -70,7 +70,7 @@ static bool udl_get_edid(struct udl_device *udl, u8 **result_buff, > memcpy(buff_ptr, block_buff, EDID_LENGTH); > kfree(block_buff); > buff_ptr += EDID_LENGTH; > - for (i = 1; i < extensions; ++i) { > + for (i = 1; i <= extensions; ++i) { > if (udl_get_edid_block(udl, i, buff_ptr)) { > buff_ptr += EDID_LENGTH; > } else { Ugh. Why doesn't udl use drm_do_get_edid()? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/udl: Bugfix in EDID reading routine 2019-03-11 11:35 ` Jani Nikula @ 2019-03-12 4:13 ` Robert Tarasov 2019-03-12 8:01 ` Jani Nikula 0 siblings, 1 reply; 5+ messages in thread From: Robert Tarasov @ 2019-03-12 4:13 UTC (permalink / raw) To: Jani Nikula; +Cc: Dave Airlie, Maling list - DRI developers [-- Attachment #1.1: Type: text/plain, Size: 1465 bytes --] Yes, you're right. Will prepare another patch which will use drm_do_get_edid() On Mon, Mar 11, 2019 at 4:33 AM Jani Nikula <jani.nikula@linux.intel.com> wrote: > On Fri, 08 Mar 2019, Robert Tarasov <tutankhamen@chromium.org> wrote: > > Fixed bug with reading of last EDID extra block in drm/udl driver. > > Previouse approach read all the blocks except the last one. > > > > Signed-off-by: Robert Tarasov <tutankhamen@chromium.org> > > --- > > drivers/gpu/drm/udl/udl_connector.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/udl/udl_connector.c > b/drivers/gpu/drm/udl/udl_connector.c > > index c3dc1fd20cb4..68b221b9a01f 100644 > > --- a/drivers/gpu/drm/udl/udl_connector.c > > +++ b/drivers/gpu/drm/udl/udl_connector.c > > @@ -70,7 +70,7 @@ static bool udl_get_edid(struct udl_device *udl, u8 > **result_buff, > > memcpy(buff_ptr, block_buff, EDID_LENGTH); > > kfree(block_buff); > > buff_ptr += EDID_LENGTH; > > - for (i = 1; i < extensions; ++i) { > > + for (i = 1; i <= extensions; ++i) { > > if (udl_get_edid_block(udl, i, buff_ptr)) { > > buff_ptr += EDID_LENGTH; > > } else { > > Ugh. Why doesn't udl use drm_do_get_edid()? > > BR, > Jani. > > > -- > Jani Nikula, Intel Open Source Graphics Center > [-- Attachment #1.2: Type: text/html, Size: 2169 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/udl: Bugfix in EDID reading routine 2019-03-12 4:13 ` Robert Tarasov @ 2019-03-12 8:01 ` Jani Nikula 2019-03-13 1:05 ` Robert Tarasov 0 siblings, 1 reply; 5+ messages in thread From: Jani Nikula @ 2019-03-12 8:01 UTC (permalink / raw) To: Robert Tarasov; +Cc: Dave Airlie, Maling list - DRI developers On Mon, 11 Mar 2019, Robert Tarasov <tutankhamen@chromium.org> wrote: > Yes, you're right. Will prepare another patch which will use > drm_do_get_edid() Oh, you might want to have this patch first with cc: stable and all that, and do the cleanup afterwards. BR, Jani. > > On Mon, Mar 11, 2019 at 4:33 AM Jani Nikula <jani.nikula@linux.intel.com> > wrote: > >> On Fri, 08 Mar 2019, Robert Tarasov <tutankhamen@chromium.org> wrote: >> > Fixed bug with reading of last EDID extra block in drm/udl driver. >> > Previouse approach read all the blocks except the last one. >> > >> > Signed-off-by: Robert Tarasov <tutankhamen@chromium.org> >> > --- >> > drivers/gpu/drm/udl/udl_connector.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/gpu/drm/udl/udl_connector.c >> b/drivers/gpu/drm/udl/udl_connector.c >> > index c3dc1fd20cb4..68b221b9a01f 100644 >> > --- a/drivers/gpu/drm/udl/udl_connector.c >> > +++ b/drivers/gpu/drm/udl/udl_connector.c >> > @@ -70,7 +70,7 @@ static bool udl_get_edid(struct udl_device *udl, u8 >> **result_buff, >> > memcpy(buff_ptr, block_buff, EDID_LENGTH); >> > kfree(block_buff); >> > buff_ptr += EDID_LENGTH; >> > - for (i = 1; i < extensions; ++i) { >> > + for (i = 1; i <= extensions; ++i) { >> > if (udl_get_edid_block(udl, i, buff_ptr)) { >> > buff_ptr += EDID_LENGTH; >> > } else { >> >> Ugh. Why doesn't udl use drm_do_get_edid()? >> >> BR, >> Jani. >> >> >> -- >> Jani Nikula, Intel Open Source Graphics Center >> -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/udl: Bugfix in EDID reading routine 2019-03-12 8:01 ` Jani Nikula @ 2019-03-13 1:05 ` Robert Tarasov 0 siblings, 0 replies; 5+ messages in thread From: Robert Tarasov @ 2019-03-13 1:05 UTC (permalink / raw) To: Jani Nikula; +Cc: Dave Airlie, Maling list - DRI developers [-- Attachment #1.1: Type: text/plain, Size: 1974 bytes --] I've already submitted the new one. On Tue, Mar 12, 2019 at 1:02 AM Jani Nikula <jani.nikula@linux.intel.com> wrote: > On Mon, 11 Mar 2019, Robert Tarasov <tutankhamen@chromium.org> wrote: > > Yes, you're right. Will prepare another patch which will use > > drm_do_get_edid() > > Oh, you might want to have this patch first with cc: stable and all > that, and do the cleanup afterwards. > > BR, > Jani. > > > > > > On Mon, Mar 11, 2019 at 4:33 AM Jani Nikula <jani.nikula@linux.intel.com > > > > wrote: > > > >> On Fri, 08 Mar 2019, Robert Tarasov <tutankhamen@chromium.org> wrote: > >> > Fixed bug with reading of last EDID extra block in drm/udl driver. > >> > Previouse approach read all the blocks except the last one. > >> > > >> > Signed-off-by: Robert Tarasov <tutankhamen@chromium.org> > >> > --- > >> > drivers/gpu/drm/udl/udl_connector.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/gpu/drm/udl/udl_connector.c > >> b/drivers/gpu/drm/udl/udl_connector.c > >> > index c3dc1fd20cb4..68b221b9a01f 100644 > >> > --- a/drivers/gpu/drm/udl/udl_connector.c > >> > +++ b/drivers/gpu/drm/udl/udl_connector.c > >> > @@ -70,7 +70,7 @@ static bool udl_get_edid(struct udl_device *udl, u8 > >> **result_buff, > >> > memcpy(buff_ptr, block_buff, EDID_LENGTH); > >> > kfree(block_buff); > >> > buff_ptr += EDID_LENGTH; > >> > - for (i = 1; i < extensions; ++i) { > >> > + for (i = 1; i <= extensions; ++i) { > >> > if (udl_get_edid_block(udl, i, > buff_ptr)) { > >> > buff_ptr += EDID_LENGTH; > >> > } else { > >> > >> Ugh. Why doesn't udl use drm_do_get_edid()? > >> > >> BR, > >> Jani. > >> > >> > >> -- > >> Jani Nikula, Intel Open Source Graphics Center > >> > > -- > Jani Nikula, Intel Open Source Graphics Center > [-- Attachment #1.2: Type: text/html, Size: 3106 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-13 1:05 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-03-09 3:30 [PATCH] drm/udl: Bugfix in EDID reading routine Robert Tarasov 2019-03-11 11:35 ` Jani Nikula 2019-03-12 4:13 ` Robert Tarasov 2019-03-12 8:01 ` Jani Nikula 2019-03-13 1:05 ` Robert Tarasov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.