[PATCH 0/2] Fix espressobin ethernet support on mainline u-boot

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/2] Fix espressobin ethernet support on mainline u-boot
@ 2019-01-28 20:07 ` Remi Pommarel
  0 siblings, 0 replies; 11+ messages in thread
From: Remi Pommarel @ 2019-01-28 20:07 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
	Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
  Cc: devicetree, Remi Pommarel, linux-kernel, linux-arm-kernel

This patchset fixes ethernet and mv88e6341 switch support on espressobin
board when bootloader does not initialize needed registers.

This patchset should be applied along with pinctrl fixes from [1] which
have been merged in next branch of linux-pinctrl tree.

[1] https://lkml.org/lkml/2018/12/21/507

Remi Pommarel (2):
  arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
  arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
    RGMII-ID

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
 2 files changed, 12 insertions(+)

-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 0/2] Fix espressobin ethernet support on mainline u-boot
@ 2019-01-28 20:07 ` Remi Pommarel
  0 siblings, 0 replies; 11+ messages in thread
From: Remi Pommarel @ 2019-01-28 20:07 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
	Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
  Cc: linux-arm-kernel, devicetree, linux-kernel, Remi Pommarel

This patchset fixes ethernet and mv88e6341 switch support on espressobin
board when bootloader does not initialize needed registers.

This patchset should be applied along with pinctrl fixes from [1] which
have been merged in next branch of linux-pinctrl tree.

[1] https://lkml.org/lkml/2018/12/21/507

Remi Pommarel (2):
  arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
  arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
    RGMII-ID

 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
 2 files changed, 12 insertions(+)

-- 
2.20.1

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 1/2] arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
  2019-01-28 20:07 ` Remi Pommarel
@ 2019-01-28 20:07   ` Remi Pommarel
  -1 siblings, 0 replies; 11+ messages in thread
From: Remi Pommarel @ 2019-01-28 20:07 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
	Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
  Cc: devicetree, Remi Pommarel, linux-kernel, linux-arm-kernel

In order to be able to communicate with the 88e6341 switch some pins
have to be repurposed as RGMII and SMI pins.

This fixes ethernet support on system booted via a bootloader that
has not already configured those pins (e.g. mainline u-boot, or vendor
u-boot compiled without ethernet support).

Signed-off-by: Remi Pommarel <repk@triplefau.lt>
---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 2 ++
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
index 846003bb480c..b60897edc885 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
@@ -196,6 +196,8 @@
 };
 
 &eth0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&rgmii_pins>, <&smi_pins>;
 	phy-mode = "rgmii-id";
 	status = "okay";
 
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index e05594ea15fb..f61538910901 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -271,6 +271,11 @@
 					function = "mii";
 				};
 
+				smi_pins: smi-pins {
+					groups = "smi";
+					function = "smi";
+				};
+
 				sdio_pins: sdio-pins {
 					groups = "sdio_sb";
 					function = "sdio";
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 1/2] arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
@ 2019-01-28 20:07   ` Remi Pommarel
  0 siblings, 0 replies; 11+ messages in thread
From: Remi Pommarel @ 2019-01-28 20:07 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
	Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
  Cc: linux-arm-kernel, devicetree, linux-kernel, Remi Pommarel

In order to be able to communicate with the 88e6341 switch some pins
have to be repurposed as RGMII and SMI pins.

This fixes ethernet support on system booted via a bootloader that
has not already configured those pins (e.g. mainline u-boot, or vendor
u-boot compiled without ethernet support).

Signed-off-by: Remi Pommarel <repk@triplefau.lt>
---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 2 ++
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
index 846003bb480c..b60897edc885 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
@@ -196,6 +196,8 @@
 };
 
 &eth0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&rgmii_pins>, <&smi_pins>;
 	phy-mode = "rgmii-id";
 	status = "okay";
 
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index e05594ea15fb..f61538910901 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -271,6 +271,11 @@
 					function = "mii";
 				};
 
+				smi_pins: smi-pins {
+					groups = "smi";
+					function = "smi";
+				};
+
 				sdio_pins: sdio-pins {
 					groups = "sdio_sb";
 					function = "sdio";
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/2] arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID
  2019-01-28 20:07 ` Remi Pommarel
@ 2019-01-28 20:07   ` Remi Pommarel
  -1 siblings, 0 replies; 11+ messages in thread
From: Remi Pommarel @ 2019-01-28 20:07 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
	Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
  Cc: devicetree, Remi Pommarel, linux-kernel, linux-arm-kernel

The mv88e6341 ethernet switch needs the cpu port control register to be
set with TX and RX internal delay in order to work.

This fixes ethernet support on system booted via a bootloader that
has not already configured this register (e.g. mainline u-boot, or
vendor u-boot compiled without ethernet support).

Signed-off-by: Remi Pommarel <repk@triplefau.lt>
---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
index b60897edc885..86e8a1e3207f 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
@@ -156,6 +156,11 @@
 				reg = <0>;
 				label = "cpu";
 				ethernet = <&eth0>;
+				phy-mode = "rgmii-id";
+				fixed-link {
+					speed = <1000>;
+					full-duplex;
+				};
 			};
 
 			port@1 {
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 2/2] arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID
@ 2019-01-28 20:07   ` Remi Pommarel
  0 siblings, 0 replies; 11+ messages in thread
From: Remi Pommarel @ 2019-01-28 20:07 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth,
	Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
  Cc: linux-arm-kernel, devicetree, linux-kernel, Remi Pommarel

The mv88e6341 ethernet switch needs the cpu port control register to be
set with TX and RX internal delay in order to work.

This fixes ethernet support on system booted via a bootloader that
has not already configured this register (e.g. mainline u-boot, or
vendor u-boot compiled without ethernet support).

Signed-off-by: Remi Pommarel <repk@triplefau.lt>
---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
index b60897edc885..86e8a1e3207f 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
@@ -156,6 +156,11 @@
 				reg = <0>;
 				label = "cpu";
 				ethernet = <&eth0>;
+				phy-mode = "rgmii-id";
+				fixed-link {
+					speed = <1000>;
+					full-duplex;
+				};
 			};
 
 			port@1 {
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID
  2019-01-28 20:07   ` Remi Pommarel
@ 2019-01-28 20:21     ` Andrew Lunn
  -1 siblings, 0 replies; 11+ messages in thread
From: Andrew Lunn @ 2019-01-28 20:21 UTC (permalink / raw)
  To: Remi Pommarel
  Cc: Mark Rutland, devicetree, Jason Cooper, Catalin Marinas,
	Gregory Clement, Will Deacon, linux-kernel, Rob Herring,
	linux-arm-kernel, Sebastian Hesselbarth

On Mon, Jan 28, 2019 at 09:07:28PM +0100, Remi Pommarel wrote:
> The mv88e6341 ethernet switch needs the cpu port control register to be
> set with TX and RX internal delay in order to work.
> 
> This fixes ethernet support on system booted via a bootloader that
> has not already configured this register (e.g. mainline u-boot, or
> vendor u-boot compiled without ethernet support).
> 
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>

Looks sensible

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 2/2] arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID
@ 2019-01-28 20:21     ` Andrew Lunn
  0 siblings, 0 replies; 11+ messages in thread
From: Andrew Lunn @ 2019-01-28 20:21 UTC (permalink / raw)
  To: Remi Pommarel
  Cc: Jason Cooper, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
	Mark Rutland, Catalin Marinas, Will Deacon, linux-arm-kernel,
	devicetree, linux-kernel

On Mon, Jan 28, 2019 at 09:07:28PM +0100, Remi Pommarel wrote:
> The mv88e6341 ethernet switch needs the cpu port control register to be
> set with TX and RX internal delay in order to work.
> 
> This fixes ethernet support on system booted via a bootloader that
> has not already configured this register (e.g. mainline u-boot, or
> vendor u-boot compiled without ethernet support).
> 
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>

Looks sensible

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 0/2] Fix espressobin ethernet support on mainline u-boot
  2019-01-28 20:07 ` Remi Pommarel
  (?)
@ 2019-02-05 23:22   ` Gregory CLEMENT
  -1 siblings, 0 replies; 11+ messages in thread
From: Gregory CLEMENT @ 2019-02-05 23:22 UTC (permalink / raw)
  To: Remi Pommarel, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
	Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
  Cc: devicetree, Remi Pommarel, linux-kernel, linux-arm-kernel

Hi Remi,
 
 On lun., janv. 28 2019, Remi Pommarel <repk@triplefau.lt> wrote:

> This patchset fixes ethernet and mv88e6341 switch support on espressobin
> board when bootloader does not initialize needed registers.
>
> This patchset should be applied along with pinctrl fixes from [1] which
> have been merged in next branch of linux-pinctrl tree.
>
> [1] https://lkml.org/lkml/2018/12/21/507
>
> Remi Pommarel (2):
>   arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
>   arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
>     RGMII-ID
>

Both patches applied to mvebu/dt64

Thanks,

Gregory

>  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
>  2 files changed, 12 insertions(+)
>
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 0/2] Fix espressobin ethernet support on mainline u-boot
@ 2019-02-05 23:22   ` Gregory CLEMENT
  0 siblings, 0 replies; 11+ messages in thread
From: Gregory CLEMENT @ 2019-02-05 23:22 UTC (permalink / raw)
  To: Remi Pommarel, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth,
	Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
  Cc: linux-arm-kernel, devicetree, linux-kernel, Remi Pommarel

Hi Remi,
 
 On lun., janv. 28 2019, Remi Pommarel <repk@triplefau.lt> wrote:

> This patchset fixes ethernet and mv88e6341 switch support on espressobin
> board when bootloader does not initialize needed registers.
>
> This patchset should be applied along with pinctrl fixes from [1] which
> have been merged in next branch of linux-pinctrl tree.
>
> [1] https://lkml.org/lkml/2018/12/21/507
>
> Remi Pommarel (2):
>   arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
>   arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
>     RGMII-ID
>

Both patches applied to mvebu/dt64

Thanks,

Gregory

>  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
>  2 files changed, 12 insertions(+)
>
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 0/2] Fix espressobin ethernet support on mainline u-boot
@ 2019-02-05 23:22   ` Gregory CLEMENT
  0 siblings, 0 replies; 11+ messages in thread
From: Gregory CLEMENT @ 2019-02-05 23:22 UTC (permalink / raw)
  To: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
	Mark Rutland, Catalin Marinas, Will Deacon
  Cc: devicetree, Remi Pommarel, linux-kernel, linux-arm-kernel

Hi Remi,
 
 On lun., janv. 28 2019, Remi Pommarel <repk@triplefau.lt> wrote:

> This patchset fixes ethernet and mv88e6341 switch support on espressobin
> board when bootloader does not initialize needed registers.
>
> This patchset should be applied along with pinctrl fixes from [1] which
> have been merged in next branch of linux-pinctrl tree.
>
> [1] https://lkml.org/lkml/2018/12/21/507
>
> Remi Pommarel (2):
>   arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins
>   arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as
>     RGMII-ID
>

Both patches applied to mvebu/dt64

Thanks,

Gregory

>  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 7 +++++++
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi            | 5 +++++
>  2 files changed, 12 insertions(+)
>
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-02-05 23:23 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-28 20:07 [PATCH 0/2] Fix espressobin ethernet support on mainline u-boot Remi Pommarel
2019-01-28 20:07 ` Remi Pommarel
2019-01-28 20:07 ` [PATCH 1/2] arm64: dts: armada-3720-espressobin: Configure RGMII and SMI pins Remi Pommarel
2019-01-28 20:07   ` Remi Pommarel
2019-01-28 20:07 ` [PATCH 2/2] arm64: dts: armada-3720-espressobin: Set mv88e6341 cpu port as RGMII-ID Remi Pommarel
2019-01-28 20:07   ` Remi Pommarel
2019-01-28 20:21   ` Andrew Lunn
2019-01-28 20:21     ` Andrew Lunn
2019-02-05 23:22 ` [PATCH 0/2] Fix espressobin ethernet support on mainline u-boot Gregory CLEMENT
2019-02-05 23:22   ` Gregory CLEMENT
2019-02-05 23:22   ` Gregory CLEMENT

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.