All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Show machine type in error state
@ 2019-01-03 10:12 Chris Wilson
  2019-01-03 10:42 ` Lionel Landwerlin
  2019-01-03 11:08 ` ✗ Fi.CI.BAT: failure for " Patchwork
  0 siblings, 2 replies; 6+ messages in thread
From: Chris Wilson @ 2019-01-03 10:12 UTC (permalink / raw)
  To: intel-gfx

As the question of 32b/64b kernels became relevant in the light of
certain bugs, include that information in the error state.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 6238a06b6d4e..5533a741abeb 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -665,7 +665,9 @@ static void __err_print_to_sgl(struct drm_i915_error_state_buf *m,
 
 	if (*error->error_msg)
 		err_printf(m, "%s\n", error->error_msg);
-	err_printf(m, "Kernel: %s\n", init_utsname()->release);
+	err_printf(m, "Kernel: %s %s\n",
+		   init_utsname()->release,
+		   init_utsname()->machine);
 	ts = ktime_to_timespec64(error->time);
 	err_printf(m, "Time: %lld s %ld us\n",
 		   (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Show machine type in error state
  2019-01-03 10:12 [PATCH] drm/i915: Show machine type in error state Chris Wilson
@ 2019-01-03 10:42 ` Lionel Landwerlin
  2019-01-03 10:46   ` Chris Wilson
  2019-01-03 11:08 ` ✗ Fi.CI.BAT: failure for " Patchwork
  1 sibling, 1 reply; 6+ messages in thread
From: Lionel Landwerlin @ 2019-01-03 10:42 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

On 03/01/2019 10:12, Chris Wilson wrote:
> As the question of 32b/64b kernels became relevant in the light of
> certain bugs, include that information in the error state.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


I was thinking about it, thanks for doing this.

Not sure about the content of the machine field though.


Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


> ---
>   drivers/gpu/drm/i915/i915_gpu_error.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 6238a06b6d4e..5533a741abeb 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -665,7 +665,9 @@ static void __err_print_to_sgl(struct drm_i915_error_state_buf *m,
>   
>   	if (*error->error_msg)
>   		err_printf(m, "%s\n", error->error_msg);
> -	err_printf(m, "Kernel: %s\n", init_utsname()->release);
> +	err_printf(m, "Kernel: %s %s\n",
> +		   init_utsname()->release,
> +		   init_utsname()->machine);
>   	ts = ktime_to_timespec64(error->time);
>   	err_printf(m, "Time: %lld s %ld us\n",
>   		   (s64)ts.tv_sec, ts.tv_nsec / NSEC_PER_USEC);


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Show machine type in error state
  2019-01-03 10:42 ` Lionel Landwerlin
@ 2019-01-03 10:46   ` Chris Wilson
  2019-01-03 11:48     ` Lionel Landwerlin
  2019-01-03 12:29     ` Mika Kuoppala
  0 siblings, 2 replies; 6+ messages in thread
From: Chris Wilson @ 2019-01-03 10:46 UTC (permalink / raw)
  To: Lionel Landwerlin, intel-gfx

Quoting Lionel Landwerlin (2019-01-03 10:42:22)
> On 03/01/2019 10:12, Chris Wilson wrote:
> > As the question of 32b/64b kernels became relevant in the light of
> > certain bugs, include that information in the error state.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> 
> 
> I was thinking about it, thanks for doing this.
> 
> Not sure about the content of the machine field though.

uname -m
i386 or x86_64 iirc.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Show machine type in error state
  2019-01-03 10:12 [PATCH] drm/i915: Show machine type in error state Chris Wilson
  2019-01-03 10:42 ` Lionel Landwerlin
@ 2019-01-03 11:08 ` Patchwork
  1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-01-03 11:08 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Show machine type in error state
URL   : https://patchwork.freedesktop.org/series/54676/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5359 -> Patchwork_11178
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_11178 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_11178, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/54676/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_11178:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         PASS -> DMESG-FAIL

  
Known issues
------------

  Here are the changes found in Patchwork_11178 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       PASS -> DMESG-WARN [fdo#108965]

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       PASS -> FAIL [fdo#108767]

  * igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362] +1

  
#### Possible fixes ####

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
    - fi-byt-clapper:     FAIL [fdo#107362] -> PASS

  
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965


Participating hosts (51 -> 44)
------------------------------

  Additional (1): fi-hsw-peppy 
  Missing    (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-skl-6700hq fi-bdw-samus 


Build changes
-------------

    * Linux: CI_DRM_5359 -> Patchwork_11178

  CI_DRM_5359: 607472b1b273292b53b2faae2f78e12f55b882fa @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4756: 75081c6bfb9998bd7cbf35a7ac0578c683fe55a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_11178: d049b2946db371f6c0165f421f8e97582eee91e0 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

d049b2946db3 drm/i915: Show machine type in error state

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11178/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Show machine type in error state
  2019-01-03 10:46   ` Chris Wilson
@ 2019-01-03 11:48     ` Lionel Landwerlin
  2019-01-03 12:29     ` Mika Kuoppala
  1 sibling, 0 replies; 6+ messages in thread
From: Lionel Landwerlin @ 2019-01-03 11:48 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

On 03/01/2019 10:46, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2019-01-03 10:42:22)
>> On 03/01/2019 10:12, Chris Wilson wrote:
>>> As the question of 32b/64b kernels became relevant in the light of
>>> certain bugs, include that information in the error state.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>>> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>
>> I was thinking about it, thanks for doing this.
>>
>> Not sure about the content of the machine field though.
> uname -m
> i386 or x86_64 iirc.
> -Chris
>
Awesome!

You can make that :


Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>


Thanks again!

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Show machine type in error state
  2019-01-03 10:46   ` Chris Wilson
  2019-01-03 11:48     ` Lionel Landwerlin
@ 2019-01-03 12:29     ` Mika Kuoppala
  1 sibling, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2019-01-03 12:29 UTC (permalink / raw)
  To: Chris Wilson, Lionel Landwerlin, intel-gfx

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Quoting Lionel Landwerlin (2019-01-03 10:42:22)
>> On 03/01/2019 10:12, Chris Wilson wrote:
>> > As the question of 32b/64b kernels became relevant in the light of
>> > certain bugs, include that information in the error state.
>> >
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> 
>> 
>> I was thinking about it, thanks for doing this.
>> 
>> Not sure about the content of the machine field though.
>
> uname -m
> i386 or x86_64 iirc.

Yes, it shows 'x86_64'. But I am too late in here =)
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-03 12:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-03 10:12 [PATCH] drm/i915: Show machine type in error state Chris Wilson
2019-01-03 10:42 ` Lionel Landwerlin
2019-01-03 10:46   ` Chris Wilson
2019-01-03 11:48     ` Lionel Landwerlin
2019-01-03 12:29     ` Mika Kuoppala
2019-01-03 11:08 ` ✗ Fi.CI.BAT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.