All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCHv2] ath10k: fix kernel panic while reading tpc_stats
Date: Fri, 20 Apr 2018 15:49:27 +0300	[thread overview]
Message-ID: <87efjagi08.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <091e88a3479502f30683054f89c9da33@codeaurora.org> (Tamizh chelvam's message of "Tue, 27 Mar 2018 12:09:54 +0530")

Tamizh chelvam <tamizhr@codeaurora.org> writes:

> On 2018-03-26 21:19, Kalle Valo wrote:
>> Tamizh chelvam <tamizhr@codeaurora.org> writes:
>>
>>> @@ -4455,6 +4461,8 @@ void ath10k_wmi_event_pdev_tpc_config(struct
>>> ath10k *ar, struct sk_buff *skb)
>>>  		   __le32_to_cpu(ev->twice_max_rd_power) / 2,
>>>  		   __le32_to_cpu(ev->num_tx_chain),
>>>  		   __le32_to_cpu(ev->rate_max));
>>> +exit:
>>> +	complete(&ar->debug.tpc_complete);
>>>  }
>>
>> And why do you need this anyway? The commit log doesn't explain that.
>
> Previously this complete call was not there in the error case and
> without this we will get "failed to request tpc config stats: -110"
> along with the error message and this is a timeout warning. I've added
> this since we have received the event and the warning message is
> incorrect. I'll remove this complete call here since it is a harmless
> message and send the next version of a patch.

Yeah, that's a good idea. If you want to add the complete it's better to
do that in it's own patch (and with a proper explanation in the commit
log).

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2] ath10k: fix kernel panic while reading tpc_stats
Date: Fri, 20 Apr 2018 15:49:27 +0300	[thread overview]
Message-ID: <87efjagi08.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <091e88a3479502f30683054f89c9da33@codeaurora.org> (Tamizh chelvam's message of "Tue, 27 Mar 2018 12:09:54 +0530")

Tamizh chelvam <tamizhr@codeaurora.org> writes:

> On 2018-03-26 21:19, Kalle Valo wrote:
>> Tamizh chelvam <tamizhr@codeaurora.org> writes:
>>
>>> @@ -4455,6 +4461,8 @@ void ath10k_wmi_event_pdev_tpc_config(struct
>>> ath10k *ar, struct sk_buff *skb)
>>>  		   __le32_to_cpu(ev->twice_max_rd_power) / 2,
>>>  		   __le32_to_cpu(ev->num_tx_chain),
>>>  		   __le32_to_cpu(ev->rate_max));
>>> +exit:
>>> +	complete(&ar->debug.tpc_complete);
>>>  }
>>
>> And why do you need this anyway? The commit log doesn't explain that.
>
> Previously this complete call was not there in the error case and
> without this we will get "failed to request tpc config stats: -110"
> along with the error message and this is a timeout warning. I've added
> this since we have received the event and the warning message is
> incorrect. I'll remove this complete call here since it is a harmless
> message and send the next version of a patch.

Yeah, that's a good idea. If you want to add the complete it's better to
do that in it's own patch (and with a proper explanation in the commit
log).

-- 
Kalle Valo

  reply	other threads:[~2018-04-20 12:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 17:31 [PATCHv2] ath10k: fix kernel panic while reading tpc_stats Tamizh chelvam
2018-03-22 17:31 ` Tamizh chelvam
2018-03-26 15:49 ` Kalle Valo
2018-03-26 15:49   ` Kalle Valo
2018-03-27  6:39   ` Tamizh chelvam
2018-03-27  6:39     ` Tamizh chelvam
2018-04-20 12:49     ` Kalle Valo [this message]
2018-04-20 12:49       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efjagi08.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tamizhr@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.