All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH] [CI] kernel: Downgrade warning for unsafe parameters
Date: Mon, 26 Feb 2018 12:42:40 +0200	[thread overview]
Message-ID: <87efl82frz.fsf@intel.com> (raw)
In-Reply-To: <20180220171842.22452-1-chris@chris-wilson.co.uk>

On Tue, 20 Feb 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> We make use of unsafe kernel parameters in igt, which generates a
> warning and taints the kernel. The warning is unhelpful as we then need
> to filter it out again, so kill it at source.

Is your goal to upstream this or what?

BR,
Jani.

>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  kernel/params.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/params.c b/kernel/params.c
> index cc9108c2a1fd..ce89f757e6da 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -111,8 +111,8 @@ bool parameq(const char *a, const char *b)
>  static void param_check_unsafe(const struct kernel_param *kp)
>  {
>  	if (kp->flags & KERNEL_PARAM_FL_UNSAFE) {
> -		pr_warn("Setting dangerous option %s - tainting kernel\n",
> -			kp->name);
> +		pr_notice("Setting dangerous option %s - tainting kernel\n",
> +			  kp->name);
>  		add_taint(TAINT_USER, LOCKDEP_STILL_OK);
>  	}
>  }

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH] [CI] kernel: Downgrade warning for unsafe parameters
Date: Mon, 26 Feb 2018 12:42:40 +0200	[thread overview]
Message-ID: <87efl82frz.fsf@intel.com> (raw)
In-Reply-To: <20180220171842.22452-1-chris@chris-wilson.co.uk>

On Tue, 20 Feb 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> We make use of unsafe kernel parameters in igt, which generates a
> warning and taints the kernel. The warning is unhelpful as we then need
> to filter it out again, so kill it at source.

Is your goal to upstream this or what?

BR,
Jani.

>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  kernel/params.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/params.c b/kernel/params.c
> index cc9108c2a1fd..ce89f757e6da 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -111,8 +111,8 @@ bool parameq(const char *a, const char *b)
>  static void param_check_unsafe(const struct kernel_param *kp)
>  {
>  	if (kp->flags & KERNEL_PARAM_FL_UNSAFE) {
> -		pr_warn("Setting dangerous option %s - tainting kernel\n",
> -			kp->name);
> +		pr_notice("Setting dangerous option %s - tainting kernel\n",
> +			  kp->name);
>  		add_taint(TAINT_USER, LOCKDEP_STILL_OK);
>  	}
>  }

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-02-26 10:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 17:18 [igt-dev] [PATCH] [CI] kernel: Downgrade warning for unsafe parameters Chris Wilson
2018-02-20 17:18 ` Chris Wilson
2018-02-20 17:21 ` [Intel-gfx] " Chris Wilson
2018-02-20 17:21   ` Chris Wilson
2018-02-20 17:47 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-02-20 18:01 ` ✗ Fi.CI.BAT: " Patchwork
2018-02-26 10:42 ` Jani Nikula [this message]
2018-02-26 10:42   ` [igt-dev] [PATCH] [CI] " Jani Nikula
2018-02-26 10:45   ` Chris Wilson
2018-02-26 10:45     ` Chris Wilson
2018-02-26 10:59     ` [Intel-gfx] " Jani Nikula
2018-02-26 10:59       ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efl82frz.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.