Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

[Markus Armbruster <armbru@redhat.com>]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Ok I just understood Richard explanation, so this patch is WRONG and I
> need to get some real rest :(

Ha!  Get some sleep; we'll still be around in the morning ;)

> On 05/10/2017 08:52 PM, Philippe Mathieu-Daudé wrote:
>> Apply this script using:
>>
>> $ docker run -v `pwd`:`pwd` -w `pwd` petersenna/coccinelle \
>>     --sp-file scripts/coccinelle/tcg_gen_extract.cocci \
>>     --macro-file scripts/cocci-macro-file.h \
>>     --dir target \
>>     --in-place
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>
>> This is a new version of the coccinelle script addressing Richard comments and
>> trying to do it correctly. Also changed license to GPLv2+.
>>
>> The first rule matches, it calls a python2 script that basically checks the
>> target_ulong is not overflowed: (msk << ofs) >> sizeof(target_ulong) == 0
>
> WRONG
[...]

Is this script likely to be rerun in the future?  If yes, keeping it in
scripts/coccinelle/ is a good idea.  If no, I recommend to store it in
the commit message instead.