From: Richard Henderson <rth@twiddle.net>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
qemu-arm@nongnu.org
Subject: Re: [Qemu-arm] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op
Date: Wed, 10 May 2017 13:20:38 -0700 [thread overview]
Message-ID: <b258b01d-74f9-e412-5367-d8e1d72eb159@twiddle.net> (raw)
In-Reply-To: <20170510200535.13268-3-f4bug@amsat.org>
On 05/10/2017 01:05 PM, Philippe Mathieu-Daudé wrote:
> - tcg_gen_shri_i32(t1, t1, 8);
> - tcg_gen_andi_i32(t1, t1, 0x00ff00ff);
> + tcg_gen_extract_i32(t1, t1, 8, 0x00ff00ff);
This is very wrong. See my previous comment.
r~
WARNING: multiple messages have this Message-ID (diff)
From: Richard Henderson <rth@twiddle.net>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op
Date: Wed, 10 May 2017 13:20:38 -0700 [thread overview]
Message-ID: <b258b01d-74f9-e412-5367-d8e1d72eb159@twiddle.net> (raw)
In-Reply-To: <20170510200535.13268-3-f4bug@amsat.org>
On 05/10/2017 01:05 PM, Philippe Mathieu-Daudé wrote:
> - tcg_gen_shri_i32(t1, t1, 8);
> - tcg_gen_andi_i32(t1, t1, 0x00ff00ff);
> + tcg_gen_extract_i32(t1, t1, 8, 0x00ff00ff);
This is very wrong. See my previous comment.
r~
next prev parent reply other threads:[~2017-05-10 20:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 20:05 [Qemu-devel] [PATCH 0/8] optimize various tcg_gen() functions using extract op Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract() Philippe Mathieu-Daudé
2017-05-10 20:12 ` Eric Blake
2017-05-10 20:23 ` Philippe Mathieu-Daudé
2017-05-10 20:19 ` Richard Henderson
2017-05-10 20:23 ` Eric Blake
2017-05-10 21:27 ` Philippe Mathieu-Daudé
2017-05-10 23:52 ` [Qemu-devel] [RFC PATCH v2] " Philippe Mathieu-Daudé
2017-05-11 0:13 ` Philippe Mathieu-Daudé
2017-05-11 9:03 ` Markus Armbruster
2017-05-12 2:01 ` Philippe Mathieu-Daudé
2017-05-12 2:04 ` Philippe Mathieu-Daudé
2017-05-15 7:04 ` Markus Armbruster
2017-05-10 20:05 ` [Qemu-devel] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op Philippe Mathieu-Daudé
2017-05-10 20:15 ` [Qemu-arm] " Eric Blake
2017-05-10 20:15 ` Eric Blake
2017-05-12 2:49 ` [Qemu-arm] " Philippe Mathieu-Daudé
2017-05-12 2:49 ` Philippe Mathieu-Daudé
2017-05-10 20:20 ` Richard Henderson [this message]
2017-05-10 20:20 ` Richard Henderson
2017-05-10 20:32 ` [Qemu-arm] " Philippe Mathieu-Daudé
2017-05-10 20:32 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-05-12 1:31 ` [Qemu-arm] " Philippe Mathieu-Daudé
2017-05-12 1:31 ` [Qemu-devel] " Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 3/8] target/arm: optimize rev16() " Philippe Mathieu-Daudé
2017-05-12 1:54 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 4/8] target/cris: optimize gen_swapb() " Philippe Mathieu-Daudé
2017-05-12 1:29 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 5/8] target/m68k: optimize bcd_flags() " Philippe Mathieu-Daudé
2017-05-11 8:41 ` Laurent Vivier
2017-05-12 1:52 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 6/8] target/mips: optimize bshfl() " Philippe Mathieu-Daudé
2017-05-12 2:13 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 7/8] target/ppc: optimize various functions " Philippe Mathieu-Daudé
2017-05-11 0:41 ` David Gibson
2017-05-11 8:46 ` [Qemu-devel] [Qemu-ppc] " Laurent Vivier
2017-05-12 5:13 ` David Gibson
2017-05-11 4:54 ` [Qemu-devel] " Nikunj A Dadhania
2017-05-12 1:48 ` Philippe Mathieu-Daudé
2017-05-12 5:16 ` David Gibson
2017-05-10 20:05 ` [Qemu-devel] [PATCH 8/8] target/sparc: " Philippe Mathieu-Daudé
2017-05-12 1:50 ` Philippe Mathieu-Daudé
2017-05-10 20:20 ` [Qemu-devel] [PATCH 0/8] optimize various tcg_gen() " no-reply
2017-05-12 2:34 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b258b01d-74f9-e412-5367-d8e1d72eb159@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.