From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
Alistair Francis <alistair.francis@xilinx.com>,
Beniamino Galvani <b.galvani@gmail.com>,
qemu-arm@nongnu.org, Antony Pavlov <antonynpavlov@gmail.com>
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH] arm: remove remaining cannot_destroy_with_object_finalize_yet
Date: Thu, 13 Apr 2017 09:06:53 +0200 [thread overview]
Message-ID: <87efwwrdki.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170412173203.20072-1-lvivier@redhat.com> (Laurent Vivier's message of "Wed, 12 Apr 2017 19:32:03 +0200")
Laurent Vivier <lvivier@redhat.com> writes:
> With commit ce5b1bbf624b ("exec: move cpu_exec_init() calls to
> realize functions"), we can now remove all the
> remaining cannot_destroy_with_object_finalize_yet as
> unsafe references have been moved to cpu_exec_realizefn().
> (tested with QOM command provided by commit 4c315c27).
Also tested with device-introspect-test :)
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Thanks, Laurent!
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Just three places marking broken devices left: versatile.c
("realview_pci" and "versatile_pci"), target/ppc/kvm.c (various ppc
CPUs). Volunteers to fix them, so we can get rid of
cannot_destroy_with_object_finalize_yet?
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Beniamino Galvani <b.galvani@gmail.com>,
qemu-arm@nongnu.org, Antony Pavlov <antonynpavlov@gmail.com>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
Alistair Francis <alistair.francis@xilinx.com>
Subject: Re: [Qemu-devel] [PATCH] arm: remove remaining cannot_destroy_with_object_finalize_yet
Date: Thu, 13 Apr 2017 09:06:53 +0200 [thread overview]
Message-ID: <87efwwrdki.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170412173203.20072-1-lvivier@redhat.com> (Laurent Vivier's message of "Wed, 12 Apr 2017 19:32:03 +0200")
Laurent Vivier <lvivier@redhat.com> writes:
> With commit ce5b1bbf624b ("exec: move cpu_exec_init() calls to
> realize functions"), we can now remove all the
> remaining cannot_destroy_with_object_finalize_yet as
> unsafe references have been moved to cpu_exec_realizefn().
> (tested with QOM command provided by commit 4c315c27).
Also tested with device-introspect-test :)
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Thanks, Laurent!
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Just three places marking broken devices left: versatile.c
("realview_pci" and "versatile_pci"), target/ppc/kvm.c (various ppc
CPUs). Volunteers to fix them, so we can get rid of
cannot_destroy_with_object_finalize_yet?
next prev parent reply other threads:[~2017-04-13 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 17:32 [Qemu-arm] [PATCH] arm: remove remaining cannot_destroy_with_object_finalize_yet Laurent Vivier
2017-04-12 17:32 ` [Qemu-devel] " Laurent Vivier
2017-04-13 7:06 ` Markus Armbruster [this message]
2017-04-13 7:06 ` Markus Armbruster
2017-04-13 8:18 ` [Qemu-arm] " Laurent Vivier
2017-04-13 8:18 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efwwrdki.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=antonynpavlov@gmail.com \
--cc=b.galvani@gmail.com \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.