* [Qemu-trivial] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example
@ 2017-02-20 16:45 ` Vincenzo Maffione
0 siblings, 0 replies; 6+ messages in thread
From: Vincenzo Maffione @ 2017-02-20 16:45 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, Vincenzo Maffione
In the vhost-user example, a chardev with id chr0 is referenced by the
vhost-user net backend, but the id is not specified in the chardev option.
Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 5633d3914f..ed22fc479a 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2127,7 +2127,7 @@ Example:
@example
qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \
-numa node,memdev=mem \
- -chardev socket,path=/path/to/socket \
+ -chardev socket,id=chr0,path=/path/to/socket \
-netdev type=vhost-user,id=net0,chardev=chr0 \
-device virtio-net-pci,netdev=net0
@end example
--
2.11.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example
@ 2017-02-20 16:45 ` Vincenzo Maffione
0 siblings, 0 replies; 6+ messages in thread
From: Vincenzo Maffione @ 2017-02-20 16:45 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, pbonzini, Vincenzo Maffione
In the vhost-user example, a chardev with id chr0 is referenced by the
vhost-user net backend, but the id is not specified in the chardev option.
Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 5633d3914f..ed22fc479a 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2127,7 +2127,7 @@ Example:
@example
qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \
-numa node,memdev=mem \
- -chardev socket,path=/path/to/socket \
+ -chardev socket,id=chr0,path=/path/to/socket \
-netdev type=vhost-user,id=net0,chardev=chr0 \
-device virtio-net-pci,netdev=net0
@end example
--
2.11.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example
2017-02-20 16:45 ` [Qemu-devel] " Vincenzo Maffione
@ 2017-02-21 9:07 ` Markus Armbruster
-1 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2017-02-21 9:07 UTC (permalink / raw)
To: Vincenzo Maffione; +Cc: qemu-devel, qemu-trivial, pbonzini
Vincenzo Maffione <v.maffione@gmail.com> writes:
> In the vhost-user example, a chardev with id chr0 is referenced by the
> vhost-user net backend, but the id is not specified in the chardev option.
>
> Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5633d3914f..ed22fc479a 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2127,7 +2127,7 @@ Example:
> @example
> qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \
> -numa node,memdev=mem \
> - -chardev socket,path=/path/to/socket \
> + -chardev socket,id=chr0,path=/path/to/socket \
> -netdev type=vhost-user,id=net0,chardev=chr0 \
> -device virtio-net-pci,netdev=net0
> @end example
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Aside: a test that extracts its test cases out of qemu-options.hx and
verifies they at least don't make startup fail would be nice. Bit-sized
task only if you have a really big jaw, I'm afraid.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example
@ 2017-02-21 9:07 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2017-02-21 9:07 UTC (permalink / raw)
To: Vincenzo Maffione; +Cc: qemu-devel, qemu-trivial, pbonzini
Vincenzo Maffione <v.maffione@gmail.com> writes:
> In the vhost-user example, a chardev with id chr0 is referenced by the
> vhost-user net backend, but the id is not specified in the chardev option.
>
> Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5633d3914f..ed22fc479a 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2127,7 +2127,7 @@ Example:
> @example
> qemu -m 512 -object memory-backend-file,id=mem,size=512M,mem-path=/hugetlbfs,share=on \
> -numa node,memdev=mem \
> - -chardev socket,path=/path/to/socket \
> + -chardev socket,id=chr0,path=/path/to/socket \
> -netdev type=vhost-user,id=net0,chardev=chr0 \
> -device virtio-net-pci,netdev=net0
> @end example
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Aside: a test that extracts its test cases out of qemu-options.hx and
verifies they at least don't make startup fail would be nice. Bit-sized
task only if you have a really big jaw, I'm afraid.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example
2017-02-20 16:45 ` [Qemu-devel] " Vincenzo Maffione
@ 2017-02-21 10:06 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2017-02-21 10:06 UTC (permalink / raw)
To: Vincenzo Maffione, qemu-devel; +Cc: qemu-trivial, pbonzini
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example
@ 2017-02-21 10:06 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2017-02-21 10:06 UTC (permalink / raw)
To: Vincenzo Maffione, qemu-devel; +Cc: qemu-trivial, pbonzini
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-21 10:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-20 16:45 [Qemu-trivial] [PATCH] qemu-options.hx: add missing id=chr0 chardev argument in vhost-user example Vincenzo Maffione
2017-02-20 16:45 ` [Qemu-devel] " Vincenzo Maffione
2017-02-21 9:07 ` [Qemu-trivial] " Markus Armbruster
2017-02-21 9:07 ` Markus Armbruster
2017-02-21 10:06 ` [Qemu-trivial] " Michael Tokarev
2017-02-21 10:06 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.