[PATCH skeleton] support for W25Q256BV

[PATCH skeleton] support for W25Q256BV

[OpenBMC Patches]

https://github.com/openbmc/skeleton/pull/26

Chris Austen (1):
  support for W25Q256BV

 objects/pflash/libflash/libflash.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.6.4

[PATCH skeleton] support for W25Q256BV

[OpenBMC Patches]

From: Chris Austen <austenc@us.ibm.com>

---
 objects/pflash/libflash/libflash.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/objects/pflash/libflash/libflash.c b/objects/pflash/libflash/libflash.c
index 01eee97..762d9e7 100644
--- a/objects/pflash/libflash/libflash.c
+++ b/objects/pflash/libflash/libflash.c
@@ -9,6 +9,7 @@ static const struct flash_info flash_info[] = {
 	{ 0xc22019, 0x02000000, FL_ERASE_ALL | FL_CAN_4B, "Macronix MXxxL25635F"},
 	{ 0xc2201a, 0x04000000, FL_ERASE_ALL | FL_CAN_4B, "Macronix MXxxL51235F"},
 	{ 0xef4018, 0x01000000, FL_ERASE_ALL,             "Winbond W25Q128BV"   },
+	{ 0xef4019, 0x02000000, FL_ERASE_ALL | FL_CAN_4B | FL_ERASE_64K|FL_ERASE_BULK,    "Winbond W25Q256BV"},
 	{ 0x20ba20, 0x04000000, FL_ERASE_4K  | FL_ERASE_64K | FL_CAN_4B |
                                 FL_ERASE_BULK | FL_MICRON_BUGS,
                                                           "Micron N25Qx512Ax"   },
-- 
2.6.4

Re: [PATCH skeleton] support for W25Q256BV

[Daniel Axtens]

[-- Attachment #1: Type: text/plain, Size: 1708 bytes --]

OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:

"What's a W25Q256BV?"

(I mean, I can see from the code that it's a flash chip, but would it be
possible to put that in the commit message please?)


> From: Chris Austen <austenc@us.ibm.com>
>
> ---
>  objects/pflash/libflash/libflash.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/objects/pflash/libflash/libflash.c b/objects/pflash/libflash/libflash.c
> index 01eee97..762d9e7 100644
> --- a/objects/pflash/libflash/libflash.c
> +++ b/objects/pflash/libflash/libflash.c
> @@ -9,6 +9,7 @@ static const struct flash_info flash_info[] = {
>  	{ 0xc22019, 0x02000000, FL_ERASE_ALL | FL_CAN_4B, "Macronix MXxxL25635F"},
>  	{ 0xc2201a, 0x04000000, FL_ERASE_ALL | FL_CAN_4B, "Macronix MXxxL51235F"},
>  	{ 0xef4018, 0x01000000, FL_ERASE_ALL,             "Winbond W25Q128BV"   },
> +	{ 0xef4019, 0x02000000, FL_ERASE_ALL | FL_CAN_4B | FL_ERASE_64K|FL_ERASE_BULK,    "Winbond W25Q256BV"},
I think this should be wrapped like the Micron below?
        { 0xef4019, 0x02000000, FL_ERASE_ALL | FL_CAN_4B |
                                FL_ERASE_64K | FL_ERASE_BULK,
                                                          "Winbond
                                                          W25Q256BV"},
>  	{ 0x20ba20, 0x04000000, FL_ERASE_4K  | FL_ERASE_64K | FL_CAN_4B |
>                                  FL_ERASE_BULK | FL_MICRON_BUGS,
>                                                            "Micron N25Qx512Ax"   },

Regards,
Daniel

> -- 
> 2.6.4
>
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

Re: [PATCH skeleton] support for W25Q256BV

[Stewart Smith]

OpenBMC Patches <openbmc-patches@stwcx.xyz> writes:
>  objects/pflash/libflash/libflash.c | 1 +

We should also *really* stop the stupidity of having a copy of pflash
laying around.

Just this week we're dealing with someone using an ancient pflash that
they got from who-knows-where with a bunch of known bugs.

Versions of software from random git revisions during development from
6+ months ago isn't a good thing.

-- 
Stewart Smith
OPAL Architect, IBM.