All of lore.kernel.org
 help / color / mirror / Atom feed
From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] ARM: dts: pxa: add clocks
Date: Mon, 09 Feb 2015 20:56:12 +0100	[thread overview]
Message-ID: <87egpy7tb7.fsf@free.fr> (raw)
In-Reply-To: <54D64BBE.9080704@cogentembedded.com> (Sergei Shtylyov's message of "Sat, 07 Feb 2015 20:30:38 +0300")

> +		ffuart: uart at 40100000 {
> +			clocks = <&pxa2xx_clks CLK_FFUART>;
> +		};
> +

After another thought about your "one line" node, I think this can be even
improved, so that :
 - uart clocks are put into pxa2xx.dtsi instead of pxa27x.dtsi
 - replace all pxa2xx_clks by clks
 - let pxa27x.dtsi, pxa3xx.dtsi declare the clks label

This way we'll have :
 - pxa2xx.dtsi
		ffuart: uart at 40100000 {
                        compatible = ...
                        ...
			clocks = <&clks CLK_FFUART>;
		};
 - pxa27x.dtsi
                clks: pxa2xx_clks at 41300004 {
                        compatible = "marvell,pxa270-clocks";
                        #clock-cells = <1>;
                        status = "okay";
                };
 - pxa3xx.dtsi
                clks: pxa3xx_clks at 41300004 {
                        compatible = "marvell,pxa300-clocks";
                        #clock-cells = <1>;
                        status = "okay";
                };

Cheers.

-- 
Robert

WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks
Date: Mon, 09 Feb 2015 20:56:12 +0100	[thread overview]
Message-ID: <87egpy7tb7.fsf@free.fr> (raw)
In-Reply-To: <54D64BBE.9080704@cogentembedded.com> (Sergei Shtylyov's message of "Sat, 07 Feb 2015 20:30:38 +0300")

> +		ffuart: uart@40100000 {
> +			clocks = <&pxa2xx_clks CLK_FFUART>;
> +		};
> +

After another thought about your "one line" node, I think this can be even
improved, so that :
 - uart clocks are put into pxa2xx.dtsi instead of pxa27x.dtsi
 - replace all pxa2xx_clks by clks
 - let pxa27x.dtsi, pxa3xx.dtsi declare the clks label

This way we'll have :
 - pxa2xx.dtsi
		ffuart: uart@40100000 {
                        compatible = ...
                        ...
			clocks = <&clks CLK_FFUART>;
		};
 - pxa27x.dtsi
                clks: pxa2xx_clks@41300004 {
                        compatible = "marvell,pxa270-clocks";
                        #clock-cells = <1>;
                        status = "okay";
                };
 - pxa3xx.dtsi
                clks: pxa3xx_clks@41300004 {
                        compatible = "marvell,pxa300-clocks";
                        #clock-cells = <1>;
                        status = "okay";
                };

Cheers.

-- 
Robert

  reply	other threads:[~2015-02-09 19:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07 12:39 [PATCH v3 1/5] ARM: dts: pxa: add pwri2c to pxa device-tree Robert Jarzmik
2015-02-07 12:39 ` Robert Jarzmik
2015-02-07 12:39 ` Robert Jarzmik
2015-02-07 12:39 ` [PATCH v3 2/5] ARM: dts: pxa: add clocks Robert Jarzmik
2015-02-07 12:39   ` Robert Jarzmik
2015-02-07 12:39   ` Robert Jarzmik
2015-02-07 12:56   ` Sergei Shtylyov
2015-02-07 12:56     ` Sergei Shtylyov
2015-02-07 12:56     ` Sergei Shtylyov
2015-02-07 13:16     ` Robert Jarzmik
2015-02-07 13:16       ` Robert Jarzmik
2015-02-07 13:16       ` Robert Jarzmik
2015-02-07 17:30       ` Sergei Shtylyov
2015-02-07 17:30         ` Sergei Shtylyov
2015-02-07 17:30         ` Sergei Shtylyov
2015-02-09 19:56         ` Robert Jarzmik [this message]
2015-02-09 19:56           ` Robert Jarzmik
2015-02-07 12:39 ` [PATCH v3 3/5] ARM: dts: pxa: add pxa27x-udc to pxa27x Robert Jarzmik
2015-02-07 12:39   ` Robert Jarzmik
2015-02-07 12:39 ` [PATCH v3 4/5] ARM: dts: pxa: add pxa27x-keypad " Robert Jarzmik
2015-02-07 12:39   ` Robert Jarzmik
2015-02-07 12:39 ` [PATCH v3 5/5] ARM: dts: pxa: add pxa-timer " Robert Jarzmik
2015-02-07 12:39   ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egpy7tb7.fsf@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.