All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Michal Kazior <michal.kazior@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Fix getting stats from firmware.
Date: Fri, 21 Mar 2014 18:12:17 +0200	[thread overview]
Message-ID: <87eh1va5um.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <532C62DE.6060309@candelatech.com> (Ben Greear's message of "Fri,  21 Mar 2014 09:03:42 -0700")

Ben Greear <greearb@candelatech.com> writes:

> On 03/20/2014 11:41 PM, Yeoh Chun-Yeow wrote:
>>>
>>> Did you test 636 as well? 636 doesn't seem to support more than just `stats_id`.
>>>
>> Nope. Tested with 636 not working.
>
> Does the existing code work with 636?  If so, we can add two different cmd
> structs and use the smaller one with 636, and the one I modified with
> 10.x firmware?

For this issue that would be the best approach. See Marek P's patch
"ath10k: update regulatory domain settings for 10.x firmware" (not yet
applied, still in ath-next-test branch) as an example how this can be
done.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: Yeoh Chun-Yeow <yeohchunyeow@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Michal Kazior <michal.kazior@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Fix getting stats from firmware.
Date: Fri, 21 Mar 2014 18:12:17 +0200	[thread overview]
Message-ID: <87eh1va5um.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <532C62DE.6060309@candelatech.com> (Ben Greear's message of "Fri, 21 Mar 2014 09:03:42 -0700")

Ben Greear <greearb@candelatech.com> writes:

> On 03/20/2014 11:41 PM, Yeoh Chun-Yeow wrote:
>>>
>>> Did you test 636 as well? 636 doesn't seem to support more than just `stats_id`.
>>>
>> Nope. Tested with 636 not working.
>
> Does the existing code work with 636?  If so, we can add two different cmd
> structs and use the smaller one with 636, and the one I modified with
> 10.x firmware?

For this issue that would be the best approach. See Marek P's patch
"ath10k: update regulatory domain settings for 10.x firmware" (not yet
applied, still in ath-next-test branch) as an example how this can be
done.

-- 
Kalle Valo

  reply	other threads:[~2014-03-21 16:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21  0:05 [PATCH] ath10k: Fix getting stats from firmware greearb
2014-03-21  0:05 ` greearb
2014-03-21  6:33 ` Michal Kazior
2014-03-21  6:33   ` Michal Kazior
2014-03-21  6:41   ` Yeoh Chun-Yeow
2014-03-21  6:41     ` Yeoh Chun-Yeow
2014-03-21 16:03     ` Ben Greear
2014-03-21 16:03       ` Ben Greear
2014-03-21 16:12       ` Kalle Valo [this message]
2014-03-21 16:12         ` Kalle Valo
2014-03-21 16:42         ` Yeoh Chun-Yeow
2014-03-21 16:42           ` Yeoh Chun-Yeow
2014-03-21 16:48           ` Yeoh Chun-Yeow
2014-03-21 16:48             ` Yeoh Chun-Yeow
2014-03-21 18:51             ` Ben Greear
2014-03-21 18:51               ` Ben Greear
2014-03-21 17:29           ` Ben Greear
2014-03-21 17:29             ` Ben Greear
2014-03-21 15:56   ` Ben Greear
2014-03-21 15:56     ` Ben Greear
2014-03-21 16:09     ` Kalle Valo
2014-03-21 16:09       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eh1va5um.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    --cc=yeohchunyeow@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.