From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: greearb@candelatech.com, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH/RFT 12/12] ath10k: add some debug prints
Date: Wed, 6 Nov 2013 14:38:49 +0200 [thread overview]
Message-ID: <87eh6tso12.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1383133346-8135-13-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 30 Oct 2013 12:42:26 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
> Some errors were handled too silently. Also add a
> print indicating BMI is booted.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> static int ath10k_pci_hif_power_up(struct ath10k *ar)
> @@ -1860,8 +1862,10 @@ static int ath10k_pci_hif_power_up(struct ath10k *ar)
> ath10k_do_pci_wake(ar);
>
> ret = ath10k_pci_ce_init(ar);
> - if (ret)
> + if (ret) {
> + ath10k_err("could not initialize CE (%d)\n", ret);
"could not initialize CE: %d\n"
That comment applies to all the error codes printed.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <greearb@candelatech.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH/RFT 12/12] ath10k: add some debug prints
Date: Wed, 6 Nov 2013 14:38:49 +0200 [thread overview]
Message-ID: <87eh6tso12.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1383133346-8135-13-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Wed, 30 Oct 2013 12:42:26 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
> Some errors were handled too silently. Also add a
> print indicating BMI is booted.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> static int ath10k_pci_hif_power_up(struct ath10k *ar)
> @@ -1860,8 +1862,10 @@ static int ath10k_pci_hif_power_up(struct ath10k *ar)
> ath10k_do_pci_wake(ar);
>
> ret = ath10k_pci_ce_init(ar);
> - if (ret)
> + if (ret) {
> + ath10k_err("could not initialize CE (%d)\n", ret);
"could not initialize CE: %d\n"
That comment applies to all the error codes printed.
--
Kalle Valo
next prev parent reply other threads:[~2013-11-06 12:39 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 11:42 [PATCH/RFT 00/12] ath10k: pci fixes 2013-10-30 Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 01/12] ath10k: remove ar_pci->ce_count Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 02/12] ath10k: don't forget to kill fw error tasklet Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 03/12] ath10k: split tasklet killing function Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 04/12] ath10k: rename function to match it's role Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-11-06 13:08 ` Kalle Valo
2013-11-06 13:08 ` Kalle Valo
2013-10-30 11:42 ` [PATCH/RFT 05/12] ath10k: make sure to mask all CE irqs Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 06/12] ath10k: fix ath10k_ce_init() failpath Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 07/12] ath10k: remove meaningless check Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 08/12] ath10k: use ath10k_do_pci_wake/sleep Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 09/12] ath10k: propagate ath10k_ce_disable_interrupts() errors Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-11-06 12:34 ` Kalle Valo
2013-11-06 12:34 ` Kalle Valo
2013-10-30 11:42 ` [PATCH/RFT 10/12] ath10k: guard against CE corruption from firmware Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 11/12] ath10k: re-arrange PCI init code Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 11:42 ` [PATCH/RFT 12/12] ath10k: add some debug prints Michal Kazior
2013-10-30 11:42 ` Michal Kazior
2013-10-30 17:16 ` Joe Perches
2013-10-30 17:16 ` Joe Perches
2013-11-06 12:43 ` Kalle Valo
2013-11-06 12:43 ` Kalle Valo
2013-11-06 12:38 ` Kalle Valo [this message]
2013-11-06 12:38 ` Kalle Valo
2013-10-30 17:06 ` [PATCH/RFT 00/12] ath10k: pci fixes 2013-10-30 Ben Greear
2013-10-30 17:06 ` Ben Greear
2013-10-30 23:41 ` Ben Greear
2013-10-30 23:41 ` Ben Greear
2013-11-08 7:01 ` [PATCHv2 00/13] " Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 01/13] ath10k: remove ar_pci->ce_count Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 02/13] ath10k: don't forget to kill fw error tasklet Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 03/13] ath10k: split tasklet killing function Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 04/13] ath10k: rename ath10k_pci_reset_target() Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 05/13] ath10k: make sure to mask all CE irqs Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 06/13] ath10k: fix ath10k_ce_init() failpath Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 07/13] ath10k: remove meaningless check Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 08/13] ath10k: use ath10k_do_pci_wake/sleep Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 09/13] ath10k: propagate ath10k_ce_disable_interrupts() errors Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 10/13] ath10k: guard against CE corruption from firmware Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 11/13] ath10k: re-arrange PCI init code Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 12/13] ath10k: add and fix some PCI prints Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-08 7:01 ` [PATCHv2 13/13] ath10k: reset device upon stopping/power down Michal Kazior
2013-11-08 7:01 ` Michal Kazior
2013-11-12 18:07 ` [PATCHv2 00/13] ath10k: pci fixes 2013-10-30 Kalle Valo
2013-11-12 18:07 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh6tso12.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.