From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Anthony Liguori" <anthony@codemonkey.ws>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 09/10] isa: Clean up use of cannot_instantiate_with_device_add_yet
Date: Thu, 24 Oct 2013 11:02:07 +0200 [thread overview]
Message-ID: <87eh7boxdc.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA81vcnhOfGAWJiuMqFzccK5adjvMcd_qEfLL4qti7Ctyw@mail.gmail.com> (Peter Maydell's message of "Wed, 23 Oct 2013 11:05:27 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On 17 October 2013 14:55, <armbru@redhat.com> wrote:
>> From: Markus Armbruster <armbru@redhat.com>
>>
>> Drop it when there's no obvious reason why device_add could not work.
>> Else keep and document why.
>>
>> * isa-fdc, port92, i8042, m48t59_isa, mc146818rtc, isa-pit, kvm-pit:
>> drop (from the last two by dropping it from their abstract base
>> pit-common)
>
> port92 needs its a20_out qemu_irq line wiring up, doesn't it?
>
> the pit devices have an output IRQ line that needs wiring up.
Good points; I'll have a second look at these two. Thanks!
next prev parent reply other threads:[~2013-10-24 9:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 13:54 [Qemu-devel] [PATCH 00/10] Clean up and fix no_user armbru
2013-10-17 13:54 ` [Qemu-devel] [PATCH 01/10] qdev: Replace no_user by cannot_instantiate_with_device_add_yet armbru
2013-10-23 10:11 ` Peter Maydell
2013-10-24 8:59 ` Markus Armbruster
2013-10-17 13:54 ` [Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_device_add_yet armbru
2013-10-23 10:13 ` Peter Maydell
2013-10-24 9:01 ` Markus Armbruster
2013-10-17 13:54 ` [Qemu-devel] [PATCH 03/10] cpu: Document why cannot_instantiate_with_device_add_yet armbru
2013-10-23 9:54 ` Peter Maydell
2013-10-17 13:54 ` [Qemu-devel] [PATCH 04/10] apic: " armbru
2013-10-23 9:54 ` Peter Maydell
2013-10-17 13:54 ` [Qemu-devel] [PATCH 05/10] pci-host: Consistently set cannot_instantiate_with_device_add_yet armbru
2013-10-23 9:51 ` Peter Maydell
2013-10-24 9:16 ` Markus Armbruster
2013-10-17 13:54 ` [Qemu-devel] [PATCH 06/10] ich9: Document why cannot_instantiate_with_device_add_yet armbru
2013-10-23 9:56 ` Peter Maydell
2013-10-17 13:54 ` [Qemu-devel] [PATCH 07/10] piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet armbru
2013-10-17 13:54 ` [Qemu-devel] [PATCH 08/10] vt82c686: " armbru
2013-10-23 9:59 ` Peter Maydell
2013-10-17 13:55 ` [Qemu-devel] [PATCH 09/10] isa: " armbru
2013-10-23 10:05 ` Peter Maydell
2013-10-24 9:02 ` Markus Armbruster [this message]
2013-10-17 13:55 ` [Qemu-devel] [PATCH 10/10] qdev: Do not let the user try to device_add when it cannot work armbru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh7boxdc.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=borntraeger@de.ibm.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.