From: Chris Ball <cjb@laptop.org>
To: wwang <wei_wang@realsil.com.cn>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"oakad@yahoo.com" <oakad@yahoo.com>,
"bp@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH v2 1/2] mmc/host/rtsx: Configure SD_CFG2 register in sd_rw_multi
Date: Mon, 19 Nov 2012 22:09:01 -0500 [thread overview]
Message-ID: <87ehjpezsi.fsf@octavius.laptop.org> (raw)
In-Reply-To: <50AAED8E.4030201@realsil.com.cn> (wwang's message of "Tue, 20 Nov 2012 10:40:14 +0800")
Hi,
On Mon, Nov 19 2012, wwang wrote:
> It's about compatibility issue. The default value of SD_CFG2 is proper
> for writing data. But for reading sequence, the timing is not good
> enough. So in some extreme circumstance, card reader may sample the
> response data from the card as good even if the data is wrong. And
> this will cause the bad consequence.
>
> Shall I modify the commit and resend the patchset again?
Thanks! Yes, please resend.
I won't be merging this one because Samuel is merging the initial
patchset, but I'll merge patches for the MMC side after 3.8. For these:
Acked-by: Chris Ball <cjb@laptop.org>
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: wwang <wei_wang@realsil.com.cn>
Cc: "sameo\@linux.intel.com" <sameo@linux.intel.com>,
"devel\@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc\@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"arnd\@arndb.de" <arnd@arndb.de>,
"oakad\@yahoo.com" <oakad@yahoo.com>,
"bp\@alien8.de" <bp@alien8.de>
Subject: Re: [PATCH v2 1/2] mmc/host/rtsx: Configure SD_CFG2 register in sd_rw_multi
Date: Mon, 19 Nov 2012 22:09:01 -0500 [thread overview]
Message-ID: <87ehjpezsi.fsf@octavius.laptop.org> (raw)
In-Reply-To: <50AAED8E.4030201@realsil.com.cn> (wwang's message of "Tue, 20 Nov 2012 10:40:14 +0800")
Hi,
On Mon, Nov 19 2012, wwang wrote:
> It's about compatibility issue. The default value of SD_CFG2 is proper
> for writing data. But for reading sequence, the timing is not good
> enough. So in some extreme circumstance, card reader may sample the
> response data from the card as good even if the data is wrong. And
> this will cause the bad consequence.
>
> Shall I modify the commit and resend the patchset again?
Thanks! Yes, please resend.
I won't be merging this one because Samuel is merging the initial
patchset, but I'll merge patches for the MMC side after 3.8. For these:
Acked-by: Chris Ball <cjb@laptop.org>
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2012-11-20 3:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 2:09 [PATCH v2 0/2] rtsx patch for for-next branch in MFD tree wei_wang
2012-11-20 2:09 ` wei_wang
2012-11-20 2:09 ` [PATCH v2 1/2] mmc/host/rtsx: Configure SD_CFG2 register in sd_rw_multi wei_wang
2012-11-20 2:09 ` wei_wang
2012-11-20 2:21 ` Chris Ball
2012-11-20 2:21 ` Chris Ball
2012-11-20 2:40 ` wwang
2012-11-20 3:09 ` Chris Ball [this message]
2012-11-20 3:09 ` Chris Ball
2012-11-20 2:09 ` [PATCH v2 2/2] mmc/host/rtsx: Explicitely include slab.h in rtsx_pci_sdmmc.c wei_wang
2012-11-20 2:09 ` wei_wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehjpezsi.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.